[239] FaF - check you answers#781
Merged
Merged
Conversation
|
This pull request is split into 4 parts for easier review. Changed files are located in these folders:
|
Contributor
Author
kennyevil
approved these changes
Jan 18, 2022
EdwinKruglov
approved these changes
Jan 19, 2022
PiperS52
approved these changes
Jan 19, 2022
| </div> | ||
| </dl> | ||
|
|
||
| <%= form.submit I18n.t("faf.contact_info.button.continue"), class: "govuk-button", role: "button" %> |
Contributor
There was a problem hiding this comment.
Just a thought, although is there perhaps some value in creating some logic in the _form.html.erb as a conditional for which button type to display, to prevent duplication across the step pages?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this PR
Screenshots of UI changes