Skip to content

FaF Mat and Feds - 'Is this the group or trust?' page#847

Merged
PiperS52 merged 11 commits into
feature/faf-group-journeyfrom
feature/303-faf-mat-and-feds-is-this-the-group-or-trust-page
Feb 10, 2022
Merged

FaF Mat and Feds - 'Is this the group or trust?' page#847
PiperS52 merged 11 commits into
feature/faf-group-journeyfrom
feature/303-faf-mat-and-feds-is-this-the-group-or-trust-page

Conversation

@PiperS52

@PiperS52 PiperS52 commented Feb 4, 2022

Copy link
Copy Markdown
Contributor

Changes in this PR

  • view for 'Is this the group or trust?' page (no DSI)

Screenshot - After

Screenshot 2022-02-09 at 17 45 07

@PiperS52 PiperS52 self-assigned this Feb 4, 2022
@viezly

viezly Bot commented Feb 4, 2022

Copy link
Copy Markdown

This pull request is split into 4 parts for easier review.
👀 Review pull request on Viezly

Changed files are located in these folders:

  • app
  • app/views/framework_requests/steps
  • config/locales
  • db
  • spec/factories/support
  • spec/features/self-serve/faf

@PiperS52 PiperS52 changed the base branch from develop to feature/faf-group-journey February 7, 2022 17:05
@PiperS52 PiperS52 marked this pull request as ready for review February 10, 2022 11:37
Comment thread spec/presenters/support/establishment_group_presenter_spec.rb Outdated
Comment thread spec/factories/support/support_establishment_group_type.rb Outdated
@EdwinKruglov

Copy link
Copy Markdown
Contributor

@PiperS52 if you remove the :nocov: comments in EstablishmentGroupsController and Support::EstablishmentGroup, the coverage shouldn't drop now that the tests hit those classes.

@kennyevil kennyevil left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things to consider here, but this mostly looks good.

Comment thread app/controllers/framework_requests_controller.rb Outdated
Comment thread app/controllers/framework_requests_controller.rb Outdated
Comment thread app/controllers/framework_requests_controller.rb Outdated
Comment thread app/views/framework_requests/steps/_step_6.html.erb Outdated
@PiperS52

Copy link
Copy Markdown
Contributor Author

@PiperS52 PiperS52 merged commit bfb27a2 into feature/faf-group-journey Feb 10, 2022
@PiperS52 PiperS52 deleted the feature/303-faf-mat-and-feds-is-this-the-group-or-trust-page branch February 10, 2022 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants