Skip to content

Case Search & Filtering#898

Merged
AndrewCowle merged 26 commits into
developfrom
feature/126-case-search
Mar 10, 2022
Merged

Case Search & Filtering#898
AndrewCowle merged 26 commits into
developfrom
feature/126-case-search

Conversation

@AndrewCowle

@AndrewCowle AndrewCowle commented Feb 23, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Changes in this PR

  • Added DRY forms for Search (with validation rules) and Filter
  • Added CaseFilter service to perform filtering based on params

Screen-shots or screen-capture of UI changes

Filtering

Screen.Recording.2022-03-08.at.08.13.08.am.mp4

AndrewCowle and others added 7 commits February 23, 2022 11:58
@AndrewCowle
Auto stash before rebase of "origin/develop"
19b7f7e
@AndrewCowle
Results placeholder
b41d18e
@EdwinKruglov @AndrewCowle
Addition of groups to the FaF journey (#873)
42741e2 
- Make navigation changes
- Add "Is this the group or trust?" page
- Add trusts to DSI journey and update kick-out page
- Add school type to non-DSI CYA page
- Add group search page
- Add "Is it a school or group?" page
- Make trust members eligible to access the service
@ryantk @AndrewCowle
Added NOTIFY_EMAIL_REPLY_TO_ID env var
4c7aa27
@ryantk @AndrewCowle
Fix rubocop error
be7bb42
@AndrewCowle
WIp
57aeb22
@AndrewCowle
Comment out old search
c20cb5c
@viezly

viezly Bot commented Feb 23, 2022 •
edited
Loading

Copy link
Copy Markdown

This pull request is split into 8 parts for easier review.
👀 Review pull request on Viezly

Changed files are located in these folders:

  • /
  • app
  • app/assets
  • app/models/support
  • app/views
  • config
  • db
  • spec/factories/support
  • spec/features/support

@peterdavidhamilton peterdavidhamilton added the enhancement New feature or request label Feb 28, 2022
peterdavidhamilton
peterdavidhamilton reviewed Mar 1, 2022
View reviewed changes
Comment thread CHANGELOG.md Outdated
Comment thread app/forms/support/case_filter_form.rb Outdated
Comment thread app/views/support/cases/forms/_filter_cases_form.html.erb Outdated
@AndrewCowle AndrewCowle marked this pull request as ready for review March 7, 2022 08:54
ryantk
ryantk suggested changes Mar 8, 2022
View reviewed changes

@ryantk ryantk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few bits and bobs to change

Comment thread app/controllers/support/cases/searches_controller.rb Outdated
Comment thread app/services/support/search_cases.rb Outdated
Comment thread app/assets/javascripts/components/toggle-panel-visibility.js Outdated
Comment thread app/forms/support/case_search_form.rb Outdated
ryantk
ryantk reviewed Mar 9, 2022
View reviewed changes
Comment thread db/views/support_case_searches_v02.sql
@AndrewCowle AndrewCowle requested a review from ryantk March 10, 2022 14:08
@AndrewCowle AndrewCowle merged commit 7879297 into develop Mar 10, 2022
@AndrewCowle AndrewCowle deleted the feature/126-case-search branch March 10, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shafiqahmedkhan shafiqahmedkhan Awaiting requested review from shafiqahmedkhan
3 more reviewers
@peterdavidhamilton peterdavidhamilton peterdavidhamilton left review comments
@kennyevil kennyevil kennyevil approved these changes
@ryantk ryantk ryantk approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@AndrewCowle AndrewCowle

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@AndrewCowle @peterdavidhamilton @kennyevil @ryantk @EdwinKruglov