remove warnings and enforce in pipeline build

.github/workflows/build-and-deploy.yml

@@ -89,7 +89,7 @@ jobs:
         run: dotnet restore
 
       - name: Build solution
-        run: dotnet build --configuration Debug
+        run: dotnet build --configuration Debug --warnings-as-errors
 
       - name: Restore .NET tools
         run: dotnet tool restore

SAPPub.Core/Interfaces/Services/KS4/Absence/ILAAbsenceRepository.cs

@@ -1,16 +1,10 @@
 using SAPPub.Core.Entities.KS4.Absence;
-using System;
-using System.Collections.Generic;
-using System.Diagnostics.CodeAnalysis;
-using System.Linq;
-using System.Text;
-using System.Threading.Tasks;
 
 namespace SAPPub.Core.Interfaces.Services.KS4.Absence
 {
     public interface ILAAbsenceService
     {
         IEnumerable<LAAbsence> GetAllLAAbsence();
-        LAAbsence? GetLAAbsence(string urn);
+        LAAbsence GetLAAbsence(string urn);
     }
 }

SAPPub.Web/Controllers/DataController.cs

@@ -14,7 +14,7 @@ public class DataController : Controller
     {
         private IEstablishmentService _service;
         private IEstablishmentAbsenceService _absenceService;
-        private ILAAbsenceService _laAbsenceService; 
+        private ILAAbsenceService _laAbsenceService;
         private IEnglandAbsenceService _englandAbsenceService;
         private IEstablishmentPerformanceService _performanceService;
         private IEstablishmentDestinationsService _destinationsService;

Tests/SAPPub.Web.Tests/UI/HomePageTests.cs

@@ -38,7 +38,7 @@ public async Task HomePage_DisplaysMainHeading()
         var heading = await Page.Locator("h1").TextContentAsync();
 
         // Assert
-        Assert.NotNull(heading.Replace(" ",""));
+        Assert.NotNull(heading?.Replace(" ", ""));
     }
 
     [Fact]

Tests/SAPPub.Web.Tests/UI/SecondarySchool/AboutSchoolPageTests.cs

@@ -1,5 +1,5 @@
-using SAPPub.Web.Tests.UI.Helpers;
-using SAPPub.Tests.UI.Infrastructure;
+using SAPPub.Tests.UI.Infrastructure;
+using SAPPub.Web.Tests.UI.Helpers;
 
 namespace SAPPub.Web.Tests.UI.SecondarySchool;
 
@@ -41,7 +41,7 @@ public async Task AboutSchoolPage_DisplaysMainHeading()
         var heading = await Page.Locator("h1").TextContentAsync();
 
         // Assert
-        Assert.NotNull(heading.Replace(" ", ""));
+        Assert.NotNull(heading?.Replace(" ", ""));
     }
 
     [Fact]

Tests/SAPPub.Web.Tests/UI/SecondarySchool/AcademicPerformanceEnglishAndMathsResultsTests.cs

@@ -43,7 +43,7 @@ public async Task AcademicPerformanceEnglishAndMathsResultsPage_DisplaysMainHead
         var heading = await Page.Locator("h1").TextContentAsync();
 
         // Assert
-        Assert.NotNull(heading.Replace(" ", ""));
+        Assert.NotNull(heading?.Replace(" ", ""));
     }
 
     [Fact]

Tests/SAPPub.Web.Tests/UI/SecondarySchool/AcademicPerformancePupilProgressTests.cs

@@ -1,5 +1,5 @@
-using SAPPub.Web.Tests.UI.Helpers;
-using SAPPub.Tests.UI.Infrastructure;
+using SAPPub.Tests.UI.Infrastructure;
+using SAPPub.Web.Tests.UI.Helpers;
 
 namespace SAPPub.Web.Tests.UI.SecondarySchool;
 
@@ -41,7 +41,7 @@ public async Task AcademicPerformancePupilProgressPage_DisplaysMainHeading()
         var heading = await Page.Locator("h1").TextContentAsync();
 
         // Assert
-        Assert.NotNull(heading.Replace(" ", ""));
+        Assert.NotNull(heading?.Replace(" ", ""));
     }
 
     [Fact]
@@ -72,7 +72,7 @@ public async Task AcademicPerformancePupilProgressPage_Displays_VerticalNavigati
         await nav.ShouldHaveOneActiveItemAsync();
         await nav.ShouldHaveActiveHrefAsync(_pageUrl);
     }
-    
+
     [Fact]
     public async Task AcademicPerformancePupilProgressPage_Displays_Sub_Navigation()
     {

Tests/SAPPub.Web.Tests/UI/SecondarySchool/AcademicPerformanceSubjectsEnteredTests.cs

@@ -41,7 +41,7 @@ public async Task AcademicPerformanceSubjectsEnteredPage_DisplaysMainHeading()
         var heading = await Page.Locator("h1").TextContentAsync();
 
         // Assert
-        Assert.NotNull(heading.Replace(" ", ""));
+        Assert.NotNull(heading?.Replace(" ", ""));
     }
 
     [Fact]

Tests/SAPPub.Web.Tests/UI/SecondarySchool/CurriculumAndExtraCurricularActivitiesTests.cs

@@ -1,5 +1,5 @@
-using SAPPub.Web.Tests.UI.Helpers;
-using SAPPub.Tests.UI.Infrastructure;
+using SAPPub.Tests.UI.Infrastructure;
+using SAPPub.Web.Tests.UI.Helpers;
 
 namespace SAPPub.Web.Tests.UI.SecondarySchool;
 
@@ -41,7 +41,7 @@ public async Task CurriculumAndExtraCurricularActivitiesPage_DisplaysMainHeading
         var heading = await Page.Locator("h1").TextContentAsync();
 
         // Assert
-        Assert.NotNull(heading.Replace(" ", ""));
+        Assert.NotNull(heading?.Replace(" ", ""));
     }
 
     [Fact]

Tests/SAPPub.Web.Tests/UI/SecondarySchool/DestinationsTests.cs

@@ -42,7 +42,7 @@ public async Task DestinationsPage_DisplaysMainHeading()
         var heading = await Page.Locator("h1").TextContentAsync();
 
         // Assert
-        Assert.NotNull(heading.Replace(" ", ""));
+        Assert.NotNull(heading?.Replace(" ", ""));
 
     }
 

Tests/SAPPub.Web.Tests/Unit/ViewComponents/VerticalNavigationTests.cs

@@ -12,7 +12,7 @@ public void Invoke_ReturnsDefaultViewWithModel()
     {
         // Arrange
         var item = new VerticalNavigationModel { URN = "1", SchoolName = "Kes", ActivePage = "About" };
-        
+
         var component = CreateComponent();
 
         // Act
@@ -24,7 +24,7 @@ public void Invoke_ReturnsDefaultViewWithModel()
 
 
         var model = result.ViewData!;
-        Assert.IsType<VerticalNavigationModel>(model.Model);  
+        Assert.IsType<VerticalNavigationModel>(model.Model);
         Assert.Equal(item.URN, ((VerticalNavigationModel)model.Model).URN);
         Assert.Equal(item.SchoolName, ((VerticalNavigationModel)model.Model).SchoolName);
         Assert.Equal(item.ActivePage, ((VerticalNavigationModel)model.Model).ActivePage);
@@ -43,6 +43,6 @@ public void Invoke_WithNullModel_DoesNotThrow()
         Assert.NotNull(result);
         Assert.Equal("~/ViewComponents/VerticalNavigation/Default.cshtml", result.ViewName);
 
-        Assert.Null(result.ViewData.Model);
+        Assert.Null(result.ViewData!.Model);
     }
 }