Enhancement unroll loops#1913
Open
lukasdreyer wants to merge 3 commits intoenhancement-ancestor_idfrom
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## enhancement-ancestor_id #1913 +/- ##
========================================================
Coverage 76.16% 76.16%
========================================================
Files 103 103
Lines 19430 19430
========================================================
Hits 14798 14798
Misses 4632 4632 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Davknapp
requested changes
Nov 21, 2025
Collaborator
Davknapp
left a comment
There was a problem hiding this comment.
Thanks for the PR! We like the idea, however we prefer a more general approach that is not gcc specific (your approach currently is, if I understand it correctly).
Have a look at https://github.com/DLR-AMR/t8code/blob/main/src/t8_helper_functions/t8_unrolled_for.hxx
a pure C++ approach to unroll loops.
An example how to use it can be found in:
https://github.com/DLR-AMR/t8code/blob/main/test/t8_types/t8_gtest_vec.cxx#L338
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1915
Describe your changes here:
Adds option to unroll loops in standalone scheme.
All these boxes must be checked by the AUTHOR before requesting review:
Documentation:,Bugfix:,Feature:,Improvement:orOther:.All these boxes must be checked by the REVIEWERS before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
Tests
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
script/find_all_source_files.scpto check the indentation of these files.License
doc/(or already has one).