Enhancement: Clean up cmesh folder. New subfolders and better structure. Only moving files.#1986
Merged
Enhancement: Clean up cmesh folder. New subfolders and better structure. Only moving files.#1986
Conversation
17 tasks
c3beee2 to
25ce806
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1986 +/- ##
=======================================
Coverage 76.52% 76.52%
=======================================
Files 106 106
Lines 18656 18656
=======================================
Hits 14276 14276
Misses 4380 4380 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Enhancement: Indent many files that were seemingly unchecked before. [2/2]
Davknapp
approved these changes
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1991
Describe your changes here:
Please note that indentation is taken for in #1987 since so many files needed indentation that it deserves its own PR.
So if all tests except indent succeed, we can merge this.
The cmesh header and source files were a mess. For example t8_cmesh.h and other files were directly in the src/ folder instead of being part of the src/t8_cmesh subfolder.
Additionally, the subfolder needed some clean up.
Here is a screenshot of the folder structure:
Before:

After:



All these boxes must be checked by the AUTHOR before requesting review:
Documentation:,Bugfix:,Feature:,Improvement:orOther:.All these boxes must be checked by the REVIEWERS before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
Tests
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
script/find_all_source_files.scpto check the indentation of these files.License
doc/(or already has one).