Improvement: clang-tidy fixes by dutkalex · Pull Request #2060 · DLR-AMR/t8code

dutkalex · 2025-12-30T17:20:46Z

Describe your changes here:
This PR consists of a handful of automated low-hanging fruit clang-tidy simplifications/modernizations.

All these boxes must be checked by the AUTHOR before requesting review:

The PR is small enough to be reviewed easily. If not, consider splitting up the changes in multiple PRs.
The title starts with one of the following prefixes: Documentation:, Bugfix:, Feature:, Improvement: or Other:.
If the PR is related to an issue, make sure to link it.
The author made sure that, as a reviewer, he/she would check all boxes below.

All these boxes must be checked by the REVIEWERS before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

The reviewer executed the new code features at least once and checked the results manually.
The code follows the t8code coding guidelines.
New source/header files are properly added to the CMake files.
The code is well documented. In particular, all function declarations, structs/classes and their members have a proper doxygen documentation. Make sure to add a file documentation for each file!
All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue).

Tests

The code is covered in an existing or new test case using Google Test.
The code coverage of the project (reported in the CI) should not decrease. If coverage is decreased, make sure that this is reasonable and acceptable.
Valgrind doesn't find any bugs in the new code. This script can be used to check for errors; see also this wiki article.

If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

Should this use case be added to the github action?
If not, does the specific use case compile and all tests pass (check manually).

Scripts and Wiki

If a new directory with source files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.
If this PR introduces a new feature, it must be covered in an example or tutorial and a Wiki article.

License

The author added a BSD statement to doc/ (or already has one).

codecov · 2025-12-31T00:15:34Z

Codecov Report

❌ Patch coverage is 70.45455% with 130 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.05%. Comparing base (4a06e41) to head (93a2b85).

Files with missing lines	Patch %	Lines
src/t8_forest/t8_forest.cxx	60.46%	34 Missing ⚠️
src/t8_cmesh/t8_cmesh_io/t8_cmesh_triangle.cxx	0.00%	20 Missing ⚠️
src/t8_cmesh/t8_cmesh_examples.cxx	20.00%	12 Missing ⚠️
src/t8_cmesh/t8_cmesh_io/t8_cmesh_save.cxx	0.00%	11 Missing ⚠️
src/t8_cmesh/t8_cmesh.cxx	85.71%	9 Missing ⚠️
src/t8_cmesh/t8_cmesh_io/t8_cmesh_readmshfile.cxx	65.00%	7 Missing ⚠️
..._geometry_implementations/t8_geometry_analytic.cxx	50.00%	7 Missing ⚠️
src/t8_vtk/t8_vtk_write_ASCII.cxx	73.07%	7 Missing ⚠️
src/t8_forest/t8_forest_ghost.cxx	86.20%	4 Missing ⚠️
.../t8_cmesh/t8_cmesh_internal/t8_cmesh_partition.cxx	91.89%	3 Missing ⚠️
... and 12 more

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2060   +/-   ##
=======================================
  Coverage   77.05%   77.05%           
=======================================
  Files         112      112           
  Lines       18959    18957    -2     
=======================================
- Hits        14608    14607    -1     
+ Misses       4351     4350    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

lenaploetzke

Thank you for your nice work! Please also merge main :)

lenaploetzke · 2026-02-04T09:39:28Z

src/t8_cmesh/t8_cmesh_internal/t8_cmesh_trees.cxx

 *
 */
-typedef struct
+using t8_part_ghost_id_and_num_atts = struct


I think only struct t8_part_ghost_id_and_num_atts {...} is even clearer in this case.

lenaploetzke · 2026-02-04T09:49:14Z

src/t8_cmesh/t8_cmesh_io/t8_cmesh_readmshfile.cxx

 * We need it to find neighbor trees.
 */
-typedef struct
+using t8_msh_file_face_t = struct


Suggested change

using t8_msh_file_face_t = struct

struct t8_msh_file_face_t

lenaploetzke · 2026-02-04T09:52:25Z

src/t8_cmesh/t8_cmesh_io/t8_cmesh_triangle.cxx

        int orientation = -1;
        int found_orientation = 0;
-        int firstvertex = face1 == 0 ? 1 : 0;
+        int const firstvertex = face1 == 0 ? 1 : 0;


Suggested change

int const firstvertex = face1 == 0 ? 1 : 0;

int const firstvertex = (face1 == 0 ? 1 : 0);

This would improve readability (although not related to your PR).

lenaploetzke · 2026-02-04T10:06:04Z

src/t8_forest/t8_forest_iterate.cxx

 * This struct stores query data about the elements within the forest.
 */
-typedef struct
+using t8_forest_child_type_query_t = struct


Suggested change

using t8_forest_child_type_query_t = struct

struct t8_forest_child_type_query_t

lenaploetzke · 2026-02-04T10:06:53Z

src/t8_forest/t8_forest_ghost.cxx

 * The information for a remote process, what data we have to send to them.
 */
-typedef struct
+using t8_ghost_mpi_send_info_t = struct


Suggested change

using t8_ghost_mpi_send_info_t = struct

struct t8_ghost_mpi_send_info_t

lenaploetzke · 2026-02-04T10:07:20Z

src/t8_forest/t8_forest_ghost.cxx

 * The data structure stored in the global_tree_to_ghost_tree hash table. 
 */
-typedef struct
+using t8_ghost_gtree_hash_t = struct


Suggested change

using t8_ghost_gtree_hash_t = struct

struct t8_ghost_gtree_hash_t

lenaploetzke · 2026-02-04T10:07:37Z

src/t8_forest/t8_forest_ghost.cxx

 * The data structure stored in the process_offsets array. 
 */
-typedef struct
+using t8_ghost_process_hash_t = struct


similar as above and for all below.

lenaploetzke · 2026-02-04T10:08:08Z

src/t8_forest/t8_forest_ghost.cxx

 * This struct stores the ghost boundary data of a forest.
 */
-typedef struct
+using t8_forest_ghost_boundary_data_t = struct


Suggested change

using t8_forest_ghost_boundary_data_t = struct

struct t8_forest_ghost_boundary_data_t

lenaploetzke · 2026-02-04T10:08:54Z

src/t8_forest/t8_forest_partition.cxx

 * we send the information stored in this struct to the other process 
 */
-typedef struct
+using t8_forest_partition_tree_info_t = struct


Suggested change

using t8_forest_partition_tree_info_t = struct

struct t8_forest_partition_tree_info_t

lenaploetzke · 2026-02-04T10:18:34Z

src/t8_vtk/t8_vtk_write_ASCII.cxx

-                                               const t8_eclass_t tree_class, const int is_ghost, FILE *vtufile,
-                                               int *columns, void **data, T8_VTK_KERNEL_MODUS modus);
+using t8_forest_vtk_cell_data_kernel
+  = int (*) (t8_forest_t, const t8_locidx_t, const t8_tree_t, const t8_locidx_t, const t8_element_t *,


Maybe we should keep the argument names here to make it easier to define custom callback with correct usage of variables.

dutkalex added 11 commits December 30, 2025 17:18

NULL -> nullptr

ddcf5ad

typedef -> using

864df8f

performance-unnecessary-value-param

edf0363

const correctness

934715b

readability-redundant-control-flow

316310b

readability-redundant-declaration

c651234

indent

5f22936

MPI_Comm -> sc_MPI_Comm bugfix

98d986f

remove debug const

10326de

Remove const to accomodate C API

c87a95f

Remove const to accomodate C API

93a2b85

lenaploetzke self-requested a review February 4, 2026 09:18

lenaploetzke reviewed Feb 4, 2026

View reviewed changes

lenaploetzke assigned dutkalex Feb 4, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improvement: clang-tidy fixes#2060

Improvement: clang-tidy fixes#2060
dutkalex wants to merge 11 commits intoDLR-AMR:mainfrom
dutkalex:clang-tidy-fixes

dutkalex commented Dec 30, 2025

Uh oh!

codecov bot commented Dec 31, 2025

Uh oh!

lenaploetzke left a comment

Uh oh!

lenaploetzke Feb 4, 2026

Uh oh!

lenaploetzke Feb 4, 2026

Uh oh!

lenaploetzke Feb 4, 2026

Uh oh!

lenaploetzke Feb 4, 2026

Uh oh!

lenaploetzke Feb 4, 2026

Uh oh!

lenaploetzke Feb 4, 2026

Uh oh!

lenaploetzke Feb 4, 2026

Uh oh!

lenaploetzke Feb 4, 2026

Uh oh!

lenaploetzke Feb 4, 2026

Uh oh!

lenaploetzke Feb 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	int const firstvertex = face1 == 0 ? 1 : 0;
	int const firstvertex = (face1 == 0 ? 1 : 0);

	using t8_forest_child_type_query_t = struct
	struct t8_forest_child_type_query_t

	using t8_ghost_mpi_send_info_t = struct
	struct t8_ghost_mpi_send_info_t

	using t8_ghost_gtree_hash_t = struct
	struct t8_ghost_gtree_hash_t

	using t8_forest_ghost_boundary_data_t = struct
	struct t8_forest_ghost_boundary_data_t

	using t8_forest_partition_tree_info_t = struct
	struct t8_forest_partition_tree_info_t

Conversation

dutkalex commented Dec 30, 2025

General

Tests

Scripts and Wiki

License

Uh oh!

codecov bot commented Dec 31, 2025

Codecov Report

Uh oh!

lenaploetzke left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants