Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2142 +/- ##
=======================================
Coverage 77.95% 77.95%
=======================================
Files 113 113
Lines 19087 19087
=======================================
Hits 14880 14880
Misses 4207 4207 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
holke
left a comment
There was a problem hiding this comment.
Great change and a good clean up of our code :)
I would suggest to put the eclass files into their own folder "eclass" and not into the element folder.
"element" should be reserved for SFC related low-level implementations and "eclass" is more related to the cmesh.
Yes, the |
holke
left a comment
There was a problem hiding this comment.
Really great clean up :)
Please resolve the merge conflicts, then we can merge.
Closes #1866
Describe your changes here:
Here is my suggestion for renaming the considered files:
All these boxes must be checked by the AUTHOR before requesting review:
Documentation:,Bugfix:,Feature:,Improvement:orOther:.All these boxes must be checked by the REVIEWERS before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
Tests
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
script/find_all_source_files.scpto check the indentation of these files.License
doc/(or already has one).