Make properties of the PooledJsEngine class are virtual#34
Merged
Daniel15 merged 1 commit intoDaniel15:masterfrom Dec 7, 2018
Taritsyn:master
Merged
Make properties of the PooledJsEngine class are virtual#34Daniel15 merged 1 commit intoDaniel15:masterfrom Taritsyn:master
PooledJsEngine class are virtual#34Daniel15 merged 1 commit intoDaniel15:masterfrom
Taritsyn:master
Conversation
Contributor
Author
|
Hello, Daniel! Need to decide what to do with this PR. |
Owner
|
Sorry, I must have missed the email for this one! I'll take a look soon.
Sent from my phone.
…On Wed, Dec 5, 2018, 10:38 PM Andrey Taritsyn ***@***.*** wrote:
Hello, Daniel!
Need to decide what to do with this PR.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#34 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAFnHSMtr8w4Oo65KjfV9v2cuLqVIxLUks5u2LtvgaJpZM4WTFmL>
.
|
Owner
|
This looks good to me! Thanks for the PR and sorry it took me so long to get to! |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To write some unit tests for the ReactJS.NET library (for example, for the
ReactEnvironmentclass) need to make properties of thePooledJsEngineclass are virtual.