This repository was archived by the owner on Apr 29, 2020. It is now read-only.
Tortoise Song now only dispels songs and rolls, food no longer removed when entering battlefield or level sync#12
Merged
teschnei merged 1 commit intoDarkstarProject:masterfrom Jan 30, 2014
maxtherabbit:master
Merged
Tortoise Song now only dispels songs and rolls, food no longer removed when entering battlefield or level sync#12teschnei merged 1 commit intoDarkstarProject:masterfrom maxtherabbit:master
teschnei merged 1 commit intoDarkstarProject:masterfrom
maxtherabbit:master
Conversation
CORE / SCRIPTS: added new EFFECTFLAG_SONG and EFFECTFLAG_ROLL, changed CAICharNormal::ActionDeath() to remove effects flagged 'FOOD' on player death SQL: removed 'DEATH' flag from food effect TODO: flag all bard songs and corsair rolls in sql
Contributor
|
i think what i'll do is revert the change to death/food, and then make a different flag for "dispels on level sync/restriction", because it's currently also clearing all debuffs (which is.. not retail at all lol) |
teschnei
added a commit
that referenced
this pull request
Jan 30, 2014
SCRIPTS: Tortoise Song now only dispels songs and rolls
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tortoise song now only dispels status effects flagged with EFFECTFLAG_SONG or EFFECTFLAG_ROLL - this is retail behavior
created new EFFECTFLAG_SONG and ROLL in status.lua and status_effect.h
removed EFFECTFLAG_DEATH from the 'food' status effect and added EFFECTFLAG_FOOD to the flags of deleted status effects on player death in the ActionDeath() function
having the 'food' effect flagged with the 'DEATH' flag was causing food effects to be removed upon level sync and entering a battlefield (non-retail behavior)
TODO: flag all bard songs and cor rolls in sql