🐛 [RUM-13693] make sure click actions are flushed on page exit#4070
🐛 [RUM-13693] make sure click actions are flushed on page exit#4070BenoitZugmeyer merged 1 commit intomainfrom
Conversation
a362e2b to
dfa55b5
Compare
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage 🔗 Commit SHA: dfa55b5 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
|
/to-staging |
|
View all feedbacks in Devflow UI.
Commit dfa55b5bfe will soon be integrated into staging-02.
Commit dfa55b5bfe has been merged into staging-02 in merge commit 4d8bdd0abd. Check out the triggered pipeline on Gitlab 🦊 If you need to revert this integration, you can use the following command: |
…g-02 Integrated commit sha: dfa55b5 Co-authored-by: BenoitZugmeyer <benoit.zugmeyer@datadoghq.com>
|
/to-staging |
|
View all feedbacks in Devflow UI.
Commit dfa55b5bfe will soon be integrated into staging-03.
Commit dfa55b5bfe has been merged into staging-03 in merge commit 99604b2262. Check out the triggered pipeline on Gitlab 🦊 If you need to revert this integration, you can use the following command: |
…g-03 Integrated commit sha: dfa55b5 Co-authored-by: BenoitZugmeyer <benoit.zugmeyer@datadoghq.com>
Motivation
When a click results in a page navigation (ex: clicking on a link), the click action is likely to be missing.
This is because whenever a click happens, we wait a bit before reporting it to compute frustration signals. As a reminder:
When the page is exiting, we don’t have time to wait for frustration signals: we should send the click action as soon as possible.
This looks like a regression brought by #3446 : since this PR, we don’t end the view anymore on unload, but we relied on the view ending to flush the click.
Changes
Stop/flush click actions whenever the page might exit.
Test instructions
To reproduce, in the sandbox, add the following:
Click on the “Soft reload” button → the click action is correctly sent
Click on the “Hard reload” button → the click action isn’t sent. With this change, the click action should be sent.
Checklist