Skip to content

♻️ inline lazyLoadRecorder into postStartStrategy using mockable()#4326

Merged
BenoitZugmeyer merged 1 commit intomainfrom
benoit/remove-load-recorder-argument
Mar 25, 2026
Merged

♻️ inline lazyLoadRecorder into postStartStrategy using mockable()#4326
BenoitZugmeyer merged 1 commit intomainfrom
benoit/remove-load-recorder-argument

Conversation

@BenoitZugmeyer
Copy link
Copy Markdown
Member

Motivation

Simplification

Changes

Removes the loadRecorder parameter from makeRecorderApi and createPostStartStrategy, simplifying call sites. Testability is preserved via replaceMockableWithSpy.

Test instructions

Minor change, if CI is green it should be fine.
You could manually test that Session Replay still works.

Checklist

  • Tested locally
  • Tested on staging
  • Added unit tests for this change.
  • Added e2e/integration tests for this change.
  • Updated documentation and/or relevant AGENTS.md file

Removes the `loadRecorder` parameter from `makeRecorderApi` and
`createPostStartStrategy`, simplifying call sites. Testability is
preserved via `replaceMockableWithSpy`.
@datadog-prod-us1-5
Copy link
Copy Markdown

datadog-prod-us1-5 bot commented Mar 13, 2026

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 77.21% (+0.00%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: f0afe08 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

@cit-pr-commenter-54b7da
Copy link
Copy Markdown

cit-pr-commenter-54b7da bot commented Mar 13, 2026

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 175.04 KiB 175.04 KiB -3 B -0.00%
Rum Profiler 6.16 KiB 6.16 KiB 0 B 0.00%
Rum Recorder 27.46 KiB 27.46 KiB 0 B 0.00%
Logs 56.84 KiB 56.84 KiB 0 B 0.00%
Flagging 944 B 944 B 0 B 0.00%
Rum Slim 130.69 KiB 130.69 KiB 0 B 0.00%
Worker 23.63 KiB 23.63 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base CPU Time (ms) Local CPU Time (ms) 𝚫%
RUM - add global context 0.0047 0.0072 +53.19%
RUM - add action 0.0153 0.0271 +77.12%
RUM - add error 0.0148 0.022 +48.65%
RUM - add timing 0.0035 0.0039 +11.43%
RUM - start view 0.0172 0.0175 +1.74%
RUM - start/stop session replay recording 0.001 0.001 0.00%
Logs - log message 0.0212 0.0276 +30.19%
🧠 Memory Performance
Action Name Base Memory Consumption Local Memory Consumption 𝚫
RUM - add global context 26.59 KiB 27.25 KiB +678 B
RUM - add action 51.97 KiB 52.95 KiB +1003 B
RUM - add timing 26.34 KiB 26.59 KiB +248 B
RUM - add error 54.66 KiB 55.96 KiB +1.30 KiB
RUM - start/stop session replay recording 25.33 KiB 25.44 KiB +118 B
RUM - start view 461.84 KiB 462.29 KiB +455 B
Logs - log message 44.77 KiB 45.10 KiB +337 B

🔗 RealWorld

@BenoitZugmeyer BenoitZugmeyer marked this pull request as ready for review March 24, 2026 13:59
@BenoitZugmeyer BenoitZugmeyer requested a review from a team as a code owner March 24, 2026 13:59
@BenoitZugmeyer BenoitZugmeyer merged commit 8dd40d5 into main Mar 25, 2026
22 checks passed
@BenoitZugmeyer BenoitZugmeyer deleted the benoit/remove-load-recorder-argument branch March 25, 2026 13:03
@github-actions github-actions bot locked and limited conversation to collaborators Mar 25, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants