✨ feat: enable LCP subparts collection by default#4368
Conversation
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: f9fa062 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
Bundles Sizes Evolution
🚀 CPU PerformancePending... 🧠 Memory Performance
|
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Removing ExperimentalFeature.LCP_SUBPARTS from the exported ExperimentalFeature enum introduces a source-compatible break for TypeScript consumers of @datadog/browser-core that still reference ExperimentalFeature.LCP_SUBPARTS in their configs/tests; after upgrading, their builds will fail even though the runtime behavior is now default-on. Keeping the enum member as a deprecated no-op alias avoids this upgrade break while still enabling subparts by default.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
BenoitZugmeyer
left a comment
There was a problem hiding this comment.
Could you adjust the PR title? 💥 is reserved for breaking changes, ✨ is for features.
Done! I was not sure since I'm removing a value from an enum if it was considered a breaking change or not |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
Motivation
This PR enables by default LCP subparts collection without the need for any feature flag
The code has been introduced in this PR
And the change is available behind a flag since v6.27.0 (release notes)
How to query in RUM
Changes
ExperimentalFeature.LCP_SUBPARTSTest instructions
Checklist