♻️ set global context in e2e worker setup#4380
Merged
thomas-lebeau merged 1 commit intomainfrom Mar 25, 2026
Merged
Conversation
Collaborator
Author
|
/trigger-ci |
|
View all feedbacks in Devflow UI.
Branch
Started pipeline #104183030 |
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: cbde1a0 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
Bundles Sizes Evolution
🚀 CPU PerformancePending... 🧠 Memory Performance
|
mormubis
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
E2E tests running with a service worker were not setting the global context (
run_id,test_name) on the SDK instances inside the worker, unlike all other test setups (bundle, async, npm, microfrontend).Changes
workerSetupnow acceptsSetupOptions(instead ofWorkerOptions+ separatecontext) and callssetGlobalContextafter each SDKinit, consistent with the other setupscreateMockServerAppsignature simplified to accept optionalSetupOptionsdirectly, replacing the individualremoteConfiguration,worker, andcontextparametersTest instructions
yarn test:e2e -g "worker"Checklist