Skip to content

Conversation

@sarahchen6
Copy link
Contributor

What Does This Do

WIP

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

Note: Once your PR is ready to merge, add it to the merge queue by commenting /merge. /merge -c cancels the queue request. /merge -f --reason "reason" skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.

@sarahchen6 sarahchen6 force-pushed the sarahchen6/migrate-benchmarks branch from a25c362 to 5b5cc66 Compare February 6, 2026 20:36
Comment on lines 338 to 344
if [[ "${BENCHMARK_TYPE}" == "startup" ]]; then
"${SCRIPT_DIR}/append-startup-report" "${TYPE_DIR}" >> "${TYPE_DIR}/comparison-baseline-vs-candidate.md" || true
elif [[ "${BENCHMARK_TYPE}" == "load" ]]; then
"${SCRIPT_DIR}/append-load-report" "${TYPE_DIR}" >> "${TYPE_DIR}/comparison-baseline-vs-candidate.md" || true
elif [[ "${BENCHMARK_TYPE}" == "dacapo" ]]; then
"${SCRIPT_DIR}/append-dacapo-report" "${TYPE_DIR}" >> "${TYPE_DIR}/comparison-baseline-vs-candidate.md" || true
fi
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should not need to append reports. each comparison-baseline-vs-candidate.md is just in its respective benchmark directory

@faydef faydef self-requested a review February 12, 2026 12:09
Copy link

@faydef faydef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To follow up on our discussion from yesterday
The steps I see to make it cleaner are the following:

  benchmark_analyzer compare pairwise \
    --baseline='{"baseline_or_candidate":"baseline"}' \
    --candidate='{"baseline_or_candidate":"candidate"}' \
    --format='$BP_FORMAT' \
    --outpath="$ARTIFACTS_DIR/comparison-baseline-vs-candidate.md" \
    "$ARTIFACTS_DIR"/baseline*.converted.json "$ARTIFACTS_DIR"/candidate*.converted.json

Adapt the blob pattern as needed

  • you can skip the setup for pr commenting using the bp-tools image and piping the md output to the pr-commenter like
    cat "$ARTIFACTS_DIR/comparison-baseline-vs-candidate.md" | pr-commenter --for-repo="$CI_PROJECT_NAME" --for-pr="$CI_COMMIT_REF_NAME" --header='$BP_HEADER' --on-duplicate=replace
    (if you want to append multiple files as comment you can use --on-duplicate=minimize)
    Let me know if anything is still unclear 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants