-
Notifications
You must be signed in to change notification settings - Fork 325
Write a description for all configurations #10571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
vpellan
wants to merge
2
commits into
master
Choose a base branch
from
vpellan/config-descriptions
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 61 metrics, 10 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.60.0-SNAPSHOT~0f4df1e4c7, baseline=1.60.0-SNAPSHOT~05a5cc2dba
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.067 s) : 0, 1066762
Total [baseline] (8.827 s) : 0, 8827467
Agent [candidate] (1.065 s) : 0, 1064844
Total [candidate] (8.76 s) : 0, 8760495
section iast
Agent [baseline] (1.239 s) : 0, 1238808
Total [baseline] (9.442 s) : 0, 9441749
Agent [candidate] (1.238 s) : 0, 1238347
Total [candidate] (9.409 s) : 0, 9409480
gantt
title insecure-bank - break down per module: candidate=1.60.0-SNAPSHOT~0f4df1e4c7, baseline=1.60.0-SNAPSHOT~05a5cc2dba
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.191 ms) : 0, 1191
crashtracking [candidate] (1.21 ms) : 0, 1210
BytebuddyAgent [baseline] (628.521 ms) : 0, 628521
BytebuddyAgent [candidate] (628.844 ms) : 0, 628844
AgentMeter [baseline] (28.931 ms) : 0, 28931
AgentMeter [candidate] (28.772 ms) : 0, 28772
GlobalTracer [baseline] (259.481 ms) : 0, 259481
GlobalTracer [candidate] (258.34 ms) : 0, 258340
AppSec [baseline] (33.155 ms) : 0, 33155
AppSec [candidate] (32.873 ms) : 0, 32873
Debugger [baseline] (59.973 ms) : 0, 59973
Debugger [candidate] (61.084 ms) : 0, 61084
Remote Config [baseline] (639.649 µs) : 0, 640
Remote Config [candidate] (616.592 µs) : 0, 617
Telemetry [baseline] (13.169 ms) : 0, 13169
Telemetry [candidate] (11.608 ms) : 0, 11608
Flare Poller [baseline] (6.189 ms) : 0, 6189
Flare Poller [candidate] (6.122 ms) : 0, 6122
section iast
crashtracking [baseline] (1.197 ms) : 0, 1197
crashtracking [candidate] (1.196 ms) : 0, 1196
BytebuddyAgent [baseline] (801.314 ms) : 0, 801314
BytebuddyAgent [candidate] (801.665 ms) : 0, 801665
AgentMeter [baseline] (11.415 ms) : 0, 11415
AgentMeter [candidate] (11.415 ms) : 0, 11415
GlobalTracer [baseline] (249.032 ms) : 0, 249032
GlobalTracer [candidate] (249.072 ms) : 0, 249072
AppSec [baseline] (33.487 ms) : 0, 33487
AppSec [candidate] (33.204 ms) : 0, 33204
Debugger [baseline] (66.792 ms) : 0, 66792
Debugger [candidate] (66.482 ms) : 0, 66482
Remote Config [baseline] (547.361 µs) : 0, 547
Remote Config [candidate] (551.64 µs) : 0, 552
Telemetry [baseline] (8.715 ms) : 0, 8715
Telemetry [candidate] (8.647 ms) : 0, 8647
Flare Poller [baseline] (3.481 ms) : 0, 3481
Flare Poller [candidate] (3.481 ms) : 0, 3481
IAST [baseline] (27.31 ms) : 0, 27310
IAST [candidate] (27.17 ms) : 0, 27170
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.60.0-SNAPSHOT~0f4df1e4c7, baseline=1.60.0-SNAPSHOT~05a5cc2dba
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.066 s) : 0, 1066467
Total [baseline] (10.911 s) : 0, 10911255
Agent [candidate] (1.068 s) : 0, 1068110
Total [candidate] (10.89 s) : 0, 10890000
section appsec
Agent [baseline] (1.258 s) : 0, 1257848
Total [baseline] (11.271 s) : 0, 11271346
Agent [candidate] (1.24 s) : 0, 1240466
Total [candidate] (11.128 s) : 0, 11127605
section iast
Agent [baseline] (1.231 s) : 0, 1231335
Total [baseline] (11.231 s) : 0, 11231326
Agent [candidate] (1.232 s) : 0, 1232234
Total [candidate] (11.319 s) : 0, 11318804
section profiling
Agent [baseline] (1.192 s) : 0, 1192463
Total [baseline] (11.099 s) : 0, 11098894
Agent [candidate] (1.193 s) : 0, 1192555
Total [candidate] (10.958 s) : 0, 10957926
gantt
title petclinic - break down per module: candidate=1.60.0-SNAPSHOT~0f4df1e4c7, baseline=1.60.0-SNAPSHOT~05a5cc2dba
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.189 ms) : 0, 1189
crashtracking [candidate] (1.192 ms) : 0, 1192
BytebuddyAgent [baseline] (628.081 ms) : 0, 628081
BytebuddyAgent [candidate] (629.685 ms) : 0, 629685
AgentMeter [baseline] (28.798 ms) : 0, 28798
AgentMeter [candidate] (28.727 ms) : 0, 28727
GlobalTracer [baseline] (258.349 ms) : 0, 258349
GlobalTracer [candidate] (258.766 ms) : 0, 258766
AppSec [baseline] (32.973 ms) : 0, 32973
AppSec [candidate] (33.145 ms) : 0, 33145
Debugger [baseline] (64.237 ms) : 0, 64237
Debugger [candidate] (62.806 ms) : 0, 62806
Remote Config [baseline] (607.688 µs) : 0, 608
Remote Config [candidate] (603.671 µs) : 0, 604
Telemetry [baseline] (10.728 ms) : 0, 10728
Telemetry [candidate] (13.115 ms) : 0, 13115
Flare Poller [baseline] (6.17 ms) : 0, 6170
Flare Poller [candidate] (4.655 ms) : 0, 4655
section appsec
crashtracking [baseline] (1.212 ms) : 0, 1212
crashtracking [candidate] (1.199 ms) : 0, 1199
BytebuddyAgent [baseline] (668.238 ms) : 0, 668238
BytebuddyAgent [candidate] (659.081 ms) : 0, 659081
AgentMeter [baseline] (12.009 ms) : 0, 12009
AgentMeter [candidate] (11.808 ms) : 0, 11808
GlobalTracer [baseline] (262.636 ms) : 0, 262636
GlobalTracer [candidate] (258.983 ms) : 0, 258983
AppSec [baseline] (170.025 ms) : 0, 170025
AppSec [candidate] (168.37 ms) : 0, 168370
Debugger [baseline] (68.168 ms) : 0, 68168
Debugger [candidate] (66.953 ms) : 0, 66953
Remote Config [baseline] (696.171 µs) : 0, 696
Remote Config [candidate] (670.16 µs) : 0, 670
Telemetry [baseline] (9.377 ms) : 0, 9377
Telemetry [candidate] (9.08 ms) : 0, 9080
Flare Poller [baseline] (3.704 ms) : 0, 3704
Flare Poller [candidate] (3.612 ms) : 0, 3612
IAST [baseline] (26.019 ms) : 0, 26019
IAST [candidate] (25.311 ms) : 0, 25311
section iast
crashtracking [baseline] (1.182 ms) : 0, 1182
crashtracking [candidate] (1.193 ms) : 0, 1193
BytebuddyAgent [baseline] (795.492 ms) : 0, 795492
BytebuddyAgent [candidate] (795.765 ms) : 0, 795765
AgentMeter [baseline] (11.115 ms) : 0, 11115
AgentMeter [candidate] (11.132 ms) : 0, 11132
GlobalTracer [baseline] (247.875 ms) : 0, 247875
GlobalTracer [candidate] (248.326 ms) : 0, 248326
AppSec [baseline] (33.751 ms) : 0, 33751
AppSec [candidate] (32.958 ms) : 0, 32958
Debugger [baseline] (66.704 ms) : 0, 66704
Debugger [candidate] (68.008 ms) : 0, 68008
Remote Config [baseline] (551.041 µs) : 0, 551
Remote Config [candidate] (548.405 µs) : 0, 548
Telemetry [baseline] (8.745 ms) : 0, 8745
Telemetry [candidate] (8.701 ms) : 0, 8701
Flare Poller [baseline] (3.491 ms) : 0, 3491
Flare Poller [candidate] (3.477 ms) : 0, 3477
IAST [baseline] (26.988 ms) : 0, 26988
IAST [candidate] (26.913 ms) : 0, 26913
section profiling
ProfilingAgent [baseline] (99.401 ms) : 0, 99401
ProfilingAgent [candidate] (99.538 ms) : 0, 99538
crashtracking [baseline] (1.224 ms) : 0, 1224
crashtracking [candidate] (1.225 ms) : 0, 1225
BytebuddyAgent [baseline] (683.164 ms) : 0, 683164
BytebuddyAgent [candidate] (683.157 ms) : 0, 683157
AgentMeter [baseline] (8.677 ms) : 0, 8677
AgentMeter [candidate] (8.643 ms) : 0, 8643
GlobalTracer [baseline] (216.281 ms) : 0, 216281
GlobalTracer [candidate] (216.703 ms) : 0, 216703
AppSec [baseline] (32.5 ms) : 0, 32500
AppSec [candidate] (32.56 ms) : 0, 32560
Debugger [baseline] (67.899 ms) : 0, 67899
Debugger [candidate] (67.58 ms) : 0, 67580
Remote Config [baseline] (597.57 µs) : 0, 598
Remote Config [candidate] (595.723 µs) : 0, 596
Telemetry [baseline] (8.907 ms) : 0, 8907
Telemetry [candidate] (8.902 ms) : 0, 8902
Flare Poller [baseline] (3.776 ms) : 0, 3776
Flare Poller [candidate] (3.747 ms) : 0, 3747
Profiling [baseline] (99.972 ms) : 0, 99972
Profiling [candidate] (100.113 ms) : 0, 100113
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 1 performance regressions! Performance is the same for 20 metrics, 15 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~0f4df1e4c7, baseline=1.60.0-SNAPSHOT~05a5cc2dba
dateFormat X
axisFormat %s
section baseline
no_agent (18.303 ms) : 18116, 18490
. : milestone, 18303,
appsec (18.587 ms) : 18400, 18773
. : milestone, 18587,
code_origins (17.756 ms) : 17582, 17930
. : milestone, 17756,
iast (18.704 ms) : 18514, 18894
. : milestone, 18704,
profiling (18.546 ms) : 18357, 18735
. : milestone, 18546,
tracing (17.713 ms) : 17538, 17888
. : milestone, 17713,
section candidate
no_agent (17.165 ms) : 16994, 17336
. : milestone, 17165,
appsec (18.454 ms) : 18269, 18640
. : milestone, 18454,
code_origins (17.49 ms) : 17316, 17663
. : milestone, 17490,
iast (18.653 ms) : 18465, 18841
. : milestone, 18653,
profiling (18.568 ms) : 18380, 18757
. : milestone, 18568,
tracing (17.412 ms) : 17242, 17583
. : milestone, 17412,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~0f4df1e4c7, baseline=1.60.0-SNAPSHOT~05a5cc2dba
dateFormat X
axisFormat %s
section baseline
no_agent (1.207 ms) : 1195, 1219
. : milestone, 1207,
iast (3.177 ms) : 3135, 3219
. : milestone, 3177,
iast_FULL (5.853 ms) : 5794, 5912
. : milestone, 5853,
iast_GLOBAL (3.58 ms) : 3518, 3642
. : milestone, 3580,
profiling (2.057 ms) : 2038, 2077
. : milestone, 2057,
tracing (1.786 ms) : 1772, 1801
. : milestone, 1786,
section candidate
no_agent (1.177 ms) : 1166, 1188
. : milestone, 1177,
iast (3.118 ms) : 3076, 3161
. : milestone, 3118,
iast_FULL (6.136 ms) : 6073, 6200
. : milestone, 6136,
iast_GLOBAL (3.556 ms) : 3490, 3621
. : milestone, 3556,
profiling (2.23 ms) : 2210, 2251
. : milestone, 2230,
tracing (1.83 ms) : 1815, 1844
. : milestone, 1830,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~0f4df1e4c7, baseline=1.60.0-SNAPSHOT~05a5cc2dba
dateFormat X
axisFormat %s
section baseline
no_agent (1.473 ms) : 1461, 1484
. : milestone, 1473,
appsec (3.751 ms) : 3530, 3972
. : milestone, 3751,
iast (2.259 ms) : 2190, 2328
. : milestone, 2259,
iast_GLOBAL (2.305 ms) : 2235, 2374
. : milestone, 2305,
profiling (2.126 ms) : 2069, 2183
. : milestone, 2126,
tracing (2.072 ms) : 2019, 2126
. : milestone, 2072,
section candidate
no_agent (1.478 ms) : 1466, 1489
. : milestone, 1478,
appsec (3.763 ms) : 3543, 3983
. : milestone, 3763,
iast (2.264 ms) : 2195, 2333
. : milestone, 2264,
iast_GLOBAL (2.303 ms) : 2234, 2373
. : milestone, 2303,
profiling (2.485 ms) : 2332, 2639
. : milestone, 2485,
tracing (2.087 ms) : 2034, 2141
. : milestone, 2087,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~0f4df1e4c7, baseline=1.60.0-SNAPSHOT~05a5cc2dba
dateFormat X
axisFormat %s
section baseline
no_agent (14.92 s) : 14920000, 14920000
. : milestone, 14920000,
appsec (14.908 s) : 14908000, 14908000
. : milestone, 14908000,
iast (18.178 s) : 18178000, 18178000
. : milestone, 18178000,
iast_GLOBAL (17.991 s) : 17991000, 17991000
. : milestone, 17991000,
profiling (15.44 s) : 15440000, 15440000
. : milestone, 15440000,
tracing (14.536 s) : 14536000, 14536000
. : milestone, 14536000,
section candidate
no_agent (15.648 s) : 15648000, 15648000
. : milestone, 15648000,
appsec (14.929 s) : 14929000, 14929000
. : milestone, 14929000,
iast (18.193 s) : 18193000, 18193000
. : milestone, 18193000,
iast_GLOBAL (17.994 s) : 17994000, 17994000
. : milestone, 17994000,
profiling (14.868 s) : 14868000, 14868000
. : milestone, 14868000,
tracing (14.577 s) : 14577000, 14577000
. : milestone, 14577000,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please do not merge this PR.
What Does This Do
It gather all existing config descriptions from FPD and public doc, and write descriptions for all configs that did not had an existing one using an LLM. In the commits, you can see the intermediary steps.
Motivation
We want to add a description on ALL existing configurations.
Additional Notes
I skipped all the DD_TRACE__ENABLED, ..._ANALYTICS_SAMPLE_RATE and ..._ANALYTICS_ENABLED configs
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.