[ci-visibility] Keep functionality with .asyncResource#2756
Merged
juan-fernandez merged 1 commit intomasterfrom Feb 2, 2023
Merged
[ci-visibility] Keep functionality with .asyncResource#2756juan-fernandez merged 1 commit intomasterfrom
.asyncResource#2756juan-fernandez merged 1 commit intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2756 +/- ##
==========================================
- Coverage 89.24% 89.23% -0.02%
==========================================
Files 314 314
Lines 10863 10865 +2
Branches 33 33
==========================================
Hits 9695 9695
- Misses 1168 1170 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
Overall package sizeSelf size: 3.73 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
BenchmarksComparing candidate commit 59eb796 in PR branch Found 1 performance improvements and 2 performance regressions! Performance is the same for 1197 cases. scenario:plugin-graphql-with-depth-on-max-16
scenario:encoders-0.4-18
scenario:plugin-http-server-with-tracer-18
|
Qard
approved these changes
Feb 2, 2023
iunanua
pushed a commit
that referenced
this pull request
Feb 6, 2023
iunanua
pushed a commit
that referenced
this pull request
Feb 6, 2023
iunanua
pushed a commit
that referenced
this pull request
Feb 7, 2023
iunanua
pushed a commit
that referenced
this pull request
Feb 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add
.asyncResourceif it's not there.Motivation
nodejs/node#46432 is going to deprecate
.asyncResourceproperty from the returned value fromasyncResource.bind. This PR is for keeping the current functionality in themochaplugin.