feat(er): Ensure APM_MULTICONFIG compat works#5156
Merged
Conversation
dd3d2b6 to
0ab3ebe
Compare
0ab3ebe to
5ef7191
Compare
cbeauchesne
approved these changes
Aug 29, 2025
Collaborator
cbeauchesne
left a comment
There was a problem hiding this comment.
Framework usage : all good (even if test_inproduct_enablement_exception_replay_apm_multiconfig will be hard to debug, but there are some test design question that should be brainstormed)
I suggest toi get a review from someone familiar with the tested feature
shatzi
approved these changes
Aug 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This is still in development for Java and Python here:
But we want to have system-tests upfront to ensure it's functioning correctly for Sept releases.
Refs: DEBUG-4399, RFC here.
Changes
service_nameandenvparameters to remote config command builders and senders inutils/_remote_config.py, allowing remote config commands to target specific services and environments. [1] [2] [3]service_targetfield, enabling precise control over which service and environment the configuration applies to.Test_Debugger_InProduct_Enablement_Exception_Replayto verify exception replay enablement behavior when multiple remote config overrides are present, including service-level and wildcard targeting.send_rc_apm_tracinginutils.pyto support the new service and environment parameters, ensuring all remote config commands can be properly targeted. [1] [2]timeto support timestamp-based filtering in tests.Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>], double-check that only<language>is impacted by the changebuild-XXX-imagelabel is present