Add support for arrow2::types::f16#104
Merged
ncpenke merged 3 commits intoDataEngineeringLabs:mainfrom Mar 18, 2023
Merged
Conversation
2 tasks
emilk
reviewed
Feb 28, 2023
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #104 +/- ##
=======================================
Coverage 94.63% 94.63%
=======================================
Files 8 8
Lines 1565 1566 +1
=======================================
+ Hits 1481 1482 +1
Misses 84 84
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jleibs
force-pushed
the
jleibs/f16_support
branch
from
29ce862 to
90e4fab
Compare
ncpenke
approved these changes
Mar 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of jorgecarleitao/arrow2#1051,
arrow2 has support for f16 through an implementation that ships with the library:
https://github.com/jorgecarleitao/arrow2/blob/562de6a6ed961eff46e7db752b384583886a5e5d/src/types/native.rs#L350
The default macros all do the right thing, they just needed to be populated.