feat: add lint.yml

.github/workflows/build-frontend.yml

@@ -1,26 +1,65 @@
-name: Build Frontend on PR
-
 on:
   push:
     branches: ["main"]
   pull_request:
     branches: ["main"]
 
 jobs:
+  lint:
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout 🛎️
+        uses: actions/checkout@v4
+
+      - name: Use Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: 16
+          cache: "npm"
+
+      - name: Install dependencies 🔧
+        run: npm ci --force
+
+      - name: Lint
+        run: npm run lint
+
+  unit-test:
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout 🛎️
+        uses: actions/checkout@v4
+
+      - name: Use Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: 16
+          cache: 'npm'
+
+      - name: Install dependencies 🔧
+        run: npm ci --force
+
+      - name: Test
+        run: npm run test:unit
+
   build:
     runs-on: ubuntu-latest
 
+    needs: [lint, unit-test]
+
     steps:
-      - uses: actions/checkout@v3
+      - name: Checkout 🛎️
+        uses: actions/checkout@v4
 
       - name: Use Node.js
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
-          node-version: 18
+          node-version: 16
           cache: 'npm'
 
-      - name: Install dependencies
+      - name: Install dependencies 🔧
         run: npm ci --force
 
-      - name: Build
-        run: yarn build
+      - name: Build 🏗️
+        run: npm run build

package.json

@@ -26,7 +26,7 @@
     "lodash": "^4.17.21",
     "normalize.css": "^8.0.1",
     "pinia": "^2.1.7",
-    "vee-validate": "^4.11.8",
+    "vee-validate": "^4.12.0",
     "vue": "^3.3.8",
     "vue-i18n": "9.7.1",
     "vue-router": "^4.2.5",

src/plugins/vee-validate/lib.d.ts

@@ -0,0 +1,21 @@
+/* eslint-disable @typescript-eslint/no-explicit-any */
+/* eslint-disable @typescript-eslint/no-unused-vars */
+import { Flags } from 'yup';
+
+type MapperFunction = (item: any) => any;
+
+declare module 'yup' {
+  // Ensure that the type parameters match the original ArraySchema declaration
+  interface ArraySchema<
+    TIn extends any[] | null | undefined = any[],
+    TContext = Record<string, any>,
+    TDefault = undefined,
+    TFlags extends Flags = ''
+  > {
+    unique(mapper: MapperFunction, label?: string): ArraySchema;
+  }
+
+  interface StringSchema {
+    s3(): StringSchema;
+  }
+}

src/plugins/vee-validate/rules.ts

@@ -1,29 +1,10 @@
-/* eslint-disable @typescript-eslint/no-unused-vars */
-/* eslint-disable @typescript-eslint/no-explicit-any */
 import { findDuplicateIndices } from '@/utils/findDuplicate';
 import { useI18n } from 'vue-i18n';
-import {
-  addMethod, array, string, Flags,
-} from 'yup'; // Import the ArraySchema type
+import { addMethod, array, string } from 'yup';
 
+// eslint-disable-next-line @typescript-eslint/no-explicit-any
 type MapperFunction = (item: any) => any;
 
-declare module 'yup' {
-  // Ensure that the type parameters match the original ArraySchema declaration
-  interface ArraySchema<
-    TIn extends any[] | null | undefined = any[],
-    TContext = Record<string, any>,
-    TDefault = undefined,
-    TFlags extends Flags = ''
-  > {
-    unique(mapper: MapperFunction, label?: string): ArraySchema;
-  }
-
-  interface StringSchema {
-    s3(): StringSchema;
-  }
-}
-
 addMethod(array, 'unique', function unique(mapper: MapperFunction, label: string) {
   const { t } = useI18n();
 

src/stores/namespace.ts

@@ -1,3 +1,4 @@
+import { nError } from '@/utils/useNoty';
 import { NAMESPACE } from '@/utils/constant';
 import { Namespace } from 'kubernetes-types/core/v1';
 import { defineStore } from 'pinia';
@@ -22,7 +23,7 @@ export const useNamespaceStore = defineStore('namespace', {
           this.setNamespace(firstNamespace.metadata?.name || '');
         }
       } catch (error) {
-        console.error('接口请求失败：', error);
+        nError('接口请求失败：', error);
       }
     },
     setNamespace(val: string) {

src/views/dataset/DatasetCreate.vue

@@ -126,13 +126,13 @@ const {
   handleSubmit,
   resetForm,
   setFieldError,
-  defineComponentBinds,
+  defineField,
 } = useForm<DatasetForRender>({
-  initialValues: dataset,
+  initialValues: dataset.value,
   validationSchema: schema,
 });
 
-const parameters = defineComponentBinds('spec.datasetMetadata.plugin.parameters', {
+const [parameters] = defineField('spec.datasetMetadata.plugin.parameters', {
   validateOnModelUpdate: false,
 });
 
@@ -476,8 +476,8 @@ const onSubmit = handleSubmit(async (values) => {
             <dao-form-item :label="$t('views.Dataset.pluginParameters')">
               <key-value-form
                 ref="componentRef"
+                v-model="parameters"
                 name="spec.datasetMetadata.plugin.parameters"
-                v-bind="parameters"
               />
             </dao-form-item>
           </template>

src/views/finetune-experiment/FinetuneExperimentCreate.vue

@@ -99,13 +99,13 @@ const validationSchema = markRaw(
 );
 
 const {
-  validate, errorBag, values, defineComponentBinds,
+  validate, errorBag, values, defineField,
 } = useForm<FinetuneExperimentForRender>({
-  initialValues: finetuneExperiment,
+  initialValues: finetuneExperiment.value,
   validationSchema,
 });
 
-const parameters = defineComponentBinds('spec.scoringConfig.parameters', {
+const [parameters] = defineField('spec.scoringConfig.parameters', {
   validateOnModelUpdate: false,
 });
 

src/views/hyperparameter/HyperparameterCreate.vue

@@ -63,7 +63,7 @@ const {
   handleSubmit,
   resetForm,
 } = useForm<Hyperparameter>({
-  initialValues: hyperparameter,
+  initialValues: hyperparameter.value,
   validationSchema: schema,
 });