Skip to content

fix: fix build.yml #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Zhuzhenghao merged 2 commits into from
Nov 28, 2023
Merged

fix: fix build.yml #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c36e4f
fix: fix build.yml
Nov 28, 2023
cbd66ab
fix: fix build.yml
Nov 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,4 +26,7 @@ jobs:
run: npm run build

- name: Docker
run: make build-image
env:
REGISTRY_USER_NAME: ${{ secrets.REGISTRY_USER_NAME }}
REGISTRY_PASSWORD: ${{ secrets.REGISTRY_PASSWORD }}
run: make release
9 changes: 8 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@ e2e-test:
.PHONY: build-image
build-image:
ls
echo "${REGISTRY_SERVER_ADDRESS}"
echo "${REGISTRY_USER_NAME}"
echo "${REGISTRY_PASSWORD}"
export DOCKER_CLI_EXPERIMENTAL=enabled ;\
! ( docker buildx ls | grep ${PKGNAME}-platform-builder ) && docker buildx create --use --platform=linux/arm64,linux/amd64 --name ${PKGNAME}-platform-builder ;\
docker buildx build \
Expand All @@ -40,7 +43,11 @@ build-image:

.PHONY: docker-login
docker-login:
docker login -u ${REGISTRY_USER_NAME} -p ${REGISTRY_PASSWORD} ${REGISTRY_SERVER_ADDRESS}
docker login -u "${REGISTRY_USER_NAME}" -p "${REGISTRY_PASSWORD}" "${REGISTRY_SERVER_ADDRESS}"

.PHONY: release
release: docker-login build-image

.PHONY: deploy-dev
deploy-dev:
kubectl -n datatunerx --kube-config ~/.kube/datatunerx set image deployment/datatunerx-ui datatunerx-ui=$(REGISTRY_REPO)/${PKGNAME}:$(IMAGE_VERSION)
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "datatunerx-consoles",
"name": "datatunerx-console",
"version": "0.0.1",
"private": true,
"scripts": {
Expand Down