forked from ESCOMP/CAM
-
Notifications
You must be signed in to change notification settings - Fork 0
Add tendencies and fluxes to variable output #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aba84ac to
a484ca5
Compare
Collaborator
Author
|
TomMelt
approved these changes
Sep 17, 2025
TomMelt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ma595 this looks good to me. Happy to merge once you have confirmed the output is correct.
4 tasks
Collaborator
Author
|
@ma595 to check output looks correct. Checked last week - gif output successful. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables
utgwandvtgwvariable output.Passes
lchnktogw_nlgw_dp_ml(state1,ptend,lchnk)as I was getting "block out of bounds" errors with ncol passed tooutfldfunction.This PR registers
UFLUX_NL,VFLUX_NL,UTGW_NLandVTGW_NLingw_nlgw_dp_initroutine usingaddfld, and then outputs tendencies usingoutfld. The following changes need to be made touser_nl_cam:I believe 'I' corresponds to instantaneous and 'A' to time averaged. Care has to be taken to register the output variables properly. This is something I need to experiment wit.
IMPORTANT: Then make sure to run
./preview_namelists.Output successfully reports write:
And
atm_inreports that UTGW and VTGW is properly registered.TODO before merging: