Open
Conversation
| COSTUME=costume) | ||
| def __init__(self, costume): | ||
| if isinstance(costume, (str, int)): | ||
| costume = core.Costume(costume) |
Owner
There was a problem hiding this comment.
I don't think int is valid here? The goal of boiga is to only emit scratch code that could have been created manually.
Author
There was a problem hiding this comment.
Scratch allows assignment of costume based on integers: try this for example
Owner
There was a problem hiding this comment.
Right, but you have to do it via a (() + (0)) block. I am open to supporting this in boiga but it needs to emit code that looks just like this.
Owner
|
Nice, could you add it to the example here too? boiga/examples/all_supported_blocks.py Lines 82 to 83 in d4bf8f9 (uncomment and add say) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements support for
CostumeNamehandling in theSetCostumeblock.