Add Folia support via reflections to support older versions.#188
Open
HarvelsX wants to merge 4 commits intoDecentSoftware-eu:mainfrom
Open
Add Folia support via reflections to support older versions.#188HarvelsX wants to merge 4 commits intoDecentSoftware-eu:mainfrom
HarvelsX wants to merge 4 commits intoDecentSoftware-eu:mainfrom
Conversation
Author
|
Implements the necessary functionality, but pampering with reflection seems overkill compared to include library. |
|
Could this get a merge? Is there unaddressed feedback here? |
|
Could this get a merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Folia support, another way...
via reflections, because you still need to maintain
targetCompatibility = 1.8...More testing is needed.