Array2D conformance to Swift.Collection#688
Open
vkondrashkov wants to merge 2 commits intoDeclarativeHub:masterfrom
Open
Array2D conformance to Swift.Collection#688vkondrashkov wants to merge 2 commits intoDeclarativeHub:masterfrom
vkondrashkov wants to merge 2 commits intoDeclarativeHub:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature proposal
I want to suggest you to extend
Array2DwithSwift.Collectionto make it possible to use this collection in enhanced methods ofCollectionViewsAlternatives
Make own
Swift.Collectionand conform it toQueryableSectionedDataSourceProtocolandSectionedDataSourceChangesetConvertibleprotocols.Motivation
I have faced with this problem at my project, when I needed to implement sectioned table view with unique cells. It's possible to solve this problem with method
bind(to:animated:rowAnimation:createCell:), but onlySectionedDataSourceChangesetConvertiblecollections are able to bind table view in such way. And framework have such one:Swift.Array. Its problem isQueryableSectionedDataSourceProtocolconformance, where it returnsnumberOfSectionsequal to 1.For this issue very convenient to use
Array2D, but it can't conform toSectionedDataSourceChangesetConvertibledue to it's not aSwift.CollectionAs a result I have created this pull request.
Additional
Documentation or tests can be appended.