Conversation
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
PSNAppz
previously requested changes
May 28, 2019
Member
There was a problem hiding this comment.
The code looks good. 2 things need to be changed though.
-
We just need to change the content part. Every website contains a
<meta content="some description" name="description">tag. We just need that information. Or if this is empty we could just grab the contents inside<body>tag. This way all the noise is removed. -
The title is not properly saved. Make sure you grab the title from
<title>tag.
PSNAppz
added
Ongoing
Machine Learning
New Feature
and removed
To Review
Enhancement
labels
Member
Author
|
The title is being saved property, I'm grabbing the text. TorBot/modules/collect_data.py Line 59 in d18083f |
Member
Author
|
This is ready to be re-reviewed |
Member
This is still not fixed? |
Member
Author
|
That was done in this commit 6520073 |
Member
|
Ready for review? |
Member
Author
|
Yep yep |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #161
Changes Proposed
thehiddenwiki.org, use--gatherto perform operation.Explanation of Changes
Save entries to csv file using the subjects of
ID | TITLE | META TAGS | CONTENT<meta>