Skip to content

Add get_images method for link.py#166

Merged
KingAkeem merged 2 commits intoDedSecInside:devfrom
kishan3:dev
Oct 1, 2019
Merged

Add get_images method for link.py#166
KingAkeem merged 2 commits intoDedSecInside:devfrom
kishan3:dev

Conversation

@kishan3
Copy link
Contributor

@kishan3 kishan3 commented Oct 1, 2019

Issue #140

Changes Proposed

  • Add get_images in link.py

Explanation of Changes

  • Image links generally are under src attribute of image.

Screenshots of new feature/change

N/A

self._links = get_links(self)
return self._links

@property
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

redefinition of unused 'links' from line 108

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in f72863d

Copy link
Member

@KingAkeem KingAkeem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM nice work!

@KingAkeem KingAkeem added this to the TorBot V1.4 milestone Oct 1, 2019
@KingAkeem KingAkeem merged commit b8ffaf9 into DedSecInside:dev Oct 1, 2019
@kishan3
Copy link
Contributor Author

kishan3 commented Oct 2, 2019

Thanks @KingAkeem !

@KingAkeem
Copy link
Member

@kishan3 No problem, thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants