Merged
Conversation
Save to file(json) feature by Yash.
Save to file(json) feature.
Member
|
@y-mehta That was fast. Great work. 👍 Our @DedSecInside/reviewers team will review this and will merge it as soon as it is ready to merge. |
PSNAppz
reviewed
Jul 25, 2017
Member
PSNAppz
left a comment
PSNAppz
left a comment
There was a problem hiding this comment.
Looks good to me. Awaiting review status from @DedSecInside/reviewers .
Contributor
|
@y-mehta can u write test cases for ur module? If possible? |
Contributor
Author
|
@agrepravin I'm sorry, but I haven't written any test cases for python till now. Still I will try to write but probably it will consume more time. |
Member
|
@y-mehta Thats ok we'll write the test cases. Thank you for the PR. |
Contributor
Author
|
Thanks @PSNAppz |
Contributor
|
No prb @y-mehta we will write but good to know how to write unit tests |
Member
|
@y-mehta You are added to our contributor list. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added :