Don't stop reading if fread returns an empty string#20
Merged
Conversation
This fixes a premature loop termination on empty string read, which can happen when reading from network streams, leading to packing truncated files silently. By explicitly checking against "false", the loop will terminate only if fread returns a failure.
This was referenced Dec 16, 2023
|
@DeepDiver1975 ping. |
Contributor
Author
|
@DeepDiver1975 any chance that you could take a look? Until this is fixed, both Nextcloud and Owncloud has this bug, and people have to keep manually editing the sources after each update, so it'd be great if you could review it :) |
8 tasks
|
@DeepDiver1975 any chance to create a new release (same for TarStreamer?) |
Contributor
Author
|
@DeepDiver1975 same request, please create new releases, so the fixes can be integrated in Nextcloud and Owncloud :) |
Owner
|
done - sorry for the delay |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a premature loop termination on empty string read, which can happen when reading from network streams, leading to packing truncated files silently.
By explicitly checking against "false", the loop will terminate only if fread returns a failure.
Fixes #19 with a minimally invasive change.