Copilot/add patch for ascend in lmdeploy#291
Merged
jinminxi104 merged 11 commits intoDeepLink-org:mainfrom Dec 29, 2025
Merged
Conversation
Co-authored-by: jinminxi104 <18713681+jinminxi104@users.noreply.github.com>
Added a comment regarding a workaround for a specific issue.
This update adds logic for prefill scheduling with kv-cache optimization, ensuring compliance with batch size and token count limits.
There was a problem hiding this comment.
Pull request overview
This PR adds a workaround patch for Ascend devices to address an incomplete prefill_attention_with_kvcache operation in lmdeploy. The patch monkey-patches the Scheduler._schedule_prefill method to add custom logic for handling prefill sequences with KV-cache optimization.
Key Changes
- Introduces
_schedule_prefill_ascendfunction that replaces the default scheduler's prefill method - Adds logic to control batching based on whether sequences have new tokens for prefill operations
- Implements early-break conditions to handle prefill-with-kvcache sequences differently
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
tangzhiyi11
reviewed
Dec 29, 2025
tangzhiyi11
approved these changes
Dec 29, 2025
jinminxi104
added a commit
to jinminxi104/dlinfer
that referenced
this pull request
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
workaround for uncompleted attention_with_kv_cache op