Skip to content

Downgrade django-tagulous to 2.1.0#13441

Merged
Maffooch merged 1 commit intodevfrom
valentijnscholten-patch-2
Oct 17, 2025
Merged

Downgrade django-tagulous to 2.1.0#13441
Maffooch merged 1 commit intodevfrom
valentijnscholten-patch-2

Conversation

@valentijnscholten
Copy link
Member

@valentijnscholten valentijnscholten commented Oct 16, 2025

Reapply changes from #13250

This is a twin PR to #13440 that goes into bugfix.

Adding this PR to go into dev to make sure it won't get lost.

Fixes #12918

Downgrade django-tagulous to 2.1.0 due to compatibility issues.
@mtesauro mtesauro requested review from Jino-T and rossops October 17, 2025 00:41
Copy link
Contributor

@Maffooch Maffooch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging since this is a dep update

@Maffooch Maffooch merged commit bc177bd into dev Oct 17, 2025
150 checks passed
@fopina
Copy link
Contributor

fopina commented Oct 17, 2025

Thanks for the heads up on this @valentijnscholten

Looking at the PR you mentioned, it looks like the change was left out, do you know if it was git merging or if it was manual conflict resolution?
I can imagine conflict resolution during this bugfix>dev merges might be quite messy.
Wondering if this has happened before and how often, whether it would make sense to think of something to prevent it

Such as adopting these "twin PRs" as you did now, as process. It's what we do at work as well (every bug fix PR is opened on minor and major branches by the author)

@valentijnscholten
Copy link
Member Author

valentijnscholten commented Oct 17, 2025

Lately we have been doing some bigger PRs and bigger release which makes these "merge master xxx into yyyy" more complex. We've decided now that these "operational" PRs should also undergo the review process to reduce the risk of regressions/mistakes. We do have quite an extensive test suite which has helped as well.

@fopina
Copy link
Contributor

fopina commented Oct 17, 2025

That's true, tests introduced are less likely to be lost in conflict resolution and they'd pick up on the misses
Bad for the UI-only fixes 😄
Tough PRs to review though!

Maybe there could be these twin PRs, but done via automation? When PR is done on bugfix, workflow cherrypicks the merge commit into a new PR for dev and assigns the author of the original PR for review?
With everything fresh in mind, quick to review the small change or resolve (few) conflicts there and takes that inital effort off you guys (maintainers). It could even be "pre-approved", so only the author needs to say ay and it gets merged immediately (and only if they change anything / resolve a conflict then maintainer approval required)

@valentijnscholten
Copy link
Member Author

valentijnscholten commented Oct 17, 2025

I considered implementing nightly automated merges/PR-creation from bugfix to dev, but haven't discussed yet with the team.

Maffooch pushed a commit to valentijnscholten/django-DefectDojo that referenced this pull request Feb 16, 2026
Downgrade django-tagulous to 2.1.0 due to compatibility issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants