Conversation
Downgrade django-tagulous to 2.1.0 due to compatibility issues.
Maffooch
left a comment
There was a problem hiding this comment.
Merging since this is a dep update
|
Thanks for the heads up on this @valentijnscholten Looking at the PR you mentioned, it looks like the change was left out, do you know if it was git merging or if it was manual conflict resolution? Such as adopting these "twin PRs" as you did now, as process. It's what we do at work as well (every bug fix PR is opened on minor and major branches by the author) |
|
Lately we have been doing some bigger PRs and bigger release which makes these "merge master xxx into yyyy" more complex. We've decided now that these "operational" PRs should also undergo the review process to reduce the risk of regressions/mistakes. We do have quite an extensive test suite which has helped as well. |
|
That's true, tests introduced are less likely to be lost in conflict resolution and they'd pick up on the misses Maybe there could be these twin PRs, but done via automation? When PR is done on |
|
I considered implementing nightly automated merges/PR-creation from bugfix to dev, but haven't discussed yet with the team. |
Downgrade django-tagulous to 2.1.0 due to compatibility issues.
Reapply changes from #13250
This is a twin PR to #13440 that goes into bugfix.
Adding this PR to go into
devto make sure it won't get lost.Fixes #12918