Provide a TypeScript version of the Action#124
Conversation
grahamc
left a comment
grahamc
left a comment
There was a problem hiding this comment.
Looking pretty good, a few nits, and then let's do a test on a few repos.
|
Let's update the action's options from |
|
@grahamc How would you suggest doing that, given that |
fetchExecutable will look for |
| FLAKEHUB_PUSH_SPDX_EXPRESSION: ${{ inputs.spdx-expression }} | ||
| FLAKEHUB_PUSH_ERROR_ON_CONFLICT: ${{ inputs.error-on-conflict }} | ||
| FLAKEHUB_PUSH_INCLUDE_OUTPUT_PATHS: ${{ inputs.include-output-paths }} | ||
| # Also GITHUB_REPOSITORY, GITHUB_REF_NAME, GITHUB_TOKEN, ACTIONS_ID_TOKEN_REQUEST_TOKEN, ACTIONS_ID_TOKEN_REQUEST_URL |
There was a problem hiding this comment.
Would be nice to keep around the documentation of these "implicit" env vars we depend on in the new TS version.
There was a problem hiding this comment.
I'm not sure we really need that, to be honest. These vars only set by the JS and are thus completely opaque to users.
cole-h
left a comment
cole-h
left a comment
There was a problem hiding this comment.
After my comments above are addressed, LGTM.
4 participants
This PR switches the Action from a Bash script to TypeScript-based logic using the
detsys-tslibrary.