removed tuples from all route parameters and base model definitions #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
callumforrester
approved these changes
Aug 18, 2022
Contributor
callumforrester
left a comment
callumforrester
left a comment
There was a problem hiding this comment.
Looks good to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is necessary because currently fastAPI does not support typing.Tuples. In order to work around this, I redefined my pydantic models to instead use other pydantic models (essentially, dataclasses) with explicit members. Where this was not possible (e.g. routes/hkl, for the scan_hkl route), I added errors to catch incorrect parameters instead.
This is part of a larger work to make swagger-codegen outputs for a java client better - Tuples are not correctly translated to an openapi schema.