Skip to content

Conversation

@rosesyrett
Copy link
Contributor

Some functionality is missing which would be useful to have:

  • getting the U/UB matrices directly.

This PR addresses this, but also modifies the routes for calculating ub and getting the status of it. Now the routes look like:

GET /ub/{name}/calculate - calculates the UB
GET /ub/{name}/ub - gets the UB matrix
GET /ub/{name}/u - gets the U matrix
GET /ub/{name}/status - gets the status of the UB object, i.e. a big string.

Copy link
Contributor

@callumforrester callumforrester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just wondering why you've installed httpx when you already have requests

@rosesyrett
Copy link
Contributor Author

Changed set_property route to:

  • set_lab_reference_vector(XyzModel) & get_lab_reference_vector()
  • set_miller_reference_vector(HklModel) & get_miller_reference_vector()
  • set_lab_surface_normal(XyzModel) & get_lab_surface_normal()
  • set_miller_surface_normal(HklModel) & get_miller_surface_normal()

@rosesyrett rosesyrett merged commit f2ab7b5 into master Nov 28, 2022
@rosesyrett rosesyrett deleted the addMoreGetRoutes branch November 28, 2022 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants