Seperate API calls from handling datastructures logic #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is from actual API calls in routes/
callumforrester
previously requested changes
Jul 14, 2022
Contributor
callumforrester
left a comment
callumforrester
left a comment
There was a problem hiding this comment.
Looks good, a few general comments:
- There's a mix of sync and async code, we should deal with that in a separate PR
- Persistence can also be more fully separated, again probably best to do that in another PR. Rough, untested example for a single endpoint here: https://github.com/RAYemelyanova/diffcalc_API/pull/4/files
- What you've called
controllersis often used to refer to what you've calledroutes, so I would name that module something different. Maybeservices?
…ntrollers/routes are too similar)
rosesyrett
dismissed
callumforrester’s stale review
I have made the requested changes and am going to make 2 new PRs to address asaync/sync issues and persistence.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
created folder to contain logic of handling API calls, to separate this from actual API calls in routes/.
Currently this feels a bit pointless, as I don't have a database to connect to. However in future, if I am needing to interact with a database for example, this could be a great help as database specific functions can go in controllers/ and not clutter anything in routes/.
Additionally, I tried to make it very clear what the dependencies are for each APIRoute instance - unpickleHKl and pickleHkl. In future, these will be removed or replaced and instead a middleware for a db connection will be added.