-
Notifications
You must be signed in to change notification settings - Fork 2
Mimas: more flexible/exensible handling of scenario #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 15 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
49eced8
Refactor mimas core using a specification pattern
9e50b36
Use bitwise operators for specification
f282022
Re-ordering
6f570ae
Move to entrypoint mechanism
4d1dc89
handle_scenario -> match_specification
d9ed071
Remove print
47d961e
Add missing specification.py
e258afd
Simplify some if/else logic
c2a3b68
Use Invocation typedef from #129
efed266
Be more explicit in matching mx beamlines
b7380de
Add test for plugin architecture
21b0712
Basic test for mimas service
589645e
Add missing import
eda0d26
from __future__ import annotations
ff1131a
Don't mix import and from ... import
8440f92
Cache list of handlers
1723563
Reduce use of inline if/else
4ca2e6b
Merge branch 'master' into mimas-specification
27578ef
Move cloud handlers to separate submodule
a0e1087
Move is_i19 definition to i19 module
aa35428
Reduce duplication in i19 handler
a678711
Explicit return False to satisfy mypy
d0ca975
Explicit type annotation to satisfy mypy
55fb13c
Explicit type annotation to satisfy mypy
1b28740
Avoid mypy incompatible type error
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.