Use pydantic in trigger service #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
September 30, 2021 10:30
Extend test coverage to include with/without spacegroup
Update database query to filter on program_id
rjgildea
force-pushed
the
pydantic-trigger
branch
from
c65e462 to
1ea521d
Compare
Co-authored-by: Markus Gerstel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChainMaprather than passing around an inner functionpydanticmodels for all trigger service methods. These automatically handle validation and type conversion from a dictionary-type mapping, e.g. using theChainMap-based approach abovepydantic.validate_argumentsdecorator to enable automatic validation and conversion to the pydantic modelThis removes a lot of boiler plate type conversions (e.g. removes 11 x
bool(parameters("automatic"))) or parameter validation/error handling, and means allows us to clearly define up front exactly what message parameters a given trigger requires.