Allow caller to skip the automatic pip module installer#258
Open
Lokomojo wants to merge 1 commit intoDiligentGraphics:masterfrom
Open
Allow caller to skip the automatic pip module installer#258Lokomojo wants to merge 1 commit intoDiligentGraphics:masterfrom
Lokomojo wants to merge 1 commit intoDiligentGraphics:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"automagically" invoking pip to install required dependencies is pretty gnarly.
Invoking it with --break-system-package is just plain scary... this can literally break systems
This patch adds a DILIGENT_SKIP_PYTHON_DEPS cmake flag to bypass this behaviour.
To be honest, my opinion is that this behaviour should be off by default, because it is genuinely dangerous, but that's up to you if you of course.