Fix: make component install atomic and revert partial filesystem chan…#5218
Open
Abhishek022001 wants to merge 1 commit intoDioxusLabs:mainfrom
Open
Fix: make component install atomic and revert partial filesystem chan…#5218Abhishek022001 wants to merge 1 commit intoDioxusLabs:mainfrom
Abhishek022001 wants to merge 1 commit intoDioxusLabs:mainfrom
Conversation
ealmloff
requested changes
Jan 15, 2026
Member
There was a problem hiding this comment.
Thanks for working on this, it would be useful to roll back changes if we run into an error, but I don't think these changes would do that.
All of the code in add_component should run after the component registry is already downloaded so the files this could potentially catch are all IO errors which could also be caused by the "atomic" commit the new code path does at the end.
To make this more atomic, we would need to:
- add a lock file for the components to make sure the registry and components folder are not being edited by two processes at the same
time - add logic to roll back changes in the
Self::Addbranch of therunfunction. There are other changes like adding dependencies we make outside of add_component
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When running
dx components listordx components addon a fresh setup (with no existing components), a failure during download or installation could leave a partially-created state under.dx/components/.Specifically:
componentsdirectory (and subdirectories) could be createdcomponent.jsonis writtenos error 2due to missing or incomplete manifestsThis leaves the CLI in a broken state that requires manual cleanup.
Solution
This PR makes component installation atomic by introducing a validation-first, commit-later flow:
.dx/components/<component>path until all validation succeedsAs a result, failures no longer leave behind partial or corrupted state.
Why this is safe
Testing
.dx/componentsstate