fix(file-explorer): prevent entering files as directories#5383
Merged
nicoburns merged 1 commit intoDioxusLabs:mainfrom Mar 18, 2026
Merged
Conversation
The file_explorer example had two issues: 1. Used heuristic (contains '.') to detect files vs directories, which is unreliable 2. Tried to enter files as directories when clicked, causing errors Changes: - Use path.is_file() for accurate file detection - Use path.is_dir() check before entering a directory - Rename shadowed 'path' variable to 'path_display' Fixes DioxusLabs#5368
nicoburns
approved these changes
Mar 17, 2026
Contributor
Author
|
Thank you for the review! This is ready to merge when you get a chance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5368
The file_explorer example had two issues:
Changes:
path.is_file()for accurate file detection in icon renderingpath.is_dir()check inenter_dir()before attempting to navigatepathvariable topath_displayfor clarityThis ensures clicking on files doesn't cause navigation errors, and files/directories are correctly identified.