Add non-exhaustive to the derived props in #[component]#5422
Open
ealmloff wants to merge 1 commit intoDioxusLabs:mainfrom
Open
Add non-exhaustive to the derived props in #[component]#5422ealmloff wants to merge 1 commit intoDioxusLabs:mainfrom
ealmloff wants to merge 1 commit intoDioxusLabs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently it is a breaking change to add an optional field to a public component with props derived with the #[component] macro even though it isn't breaking for usage within rsx. This PR adds non_exhaustive to the derived props so it isn't breaking in future releases.
Changing this component:
To this:
Is breaking because there is a public generated ButtonProps with public fields that could be constructed manually