Changed how the next active document is picked on document close.#436
Merged
Dirkster99 merged 1 commit intoDirkster99:masterfrom Aug 16, 2023
Merged
Changed how the next active document is picked on document close.#436Dirkster99 merged 1 commit intoDirkster99:masterfrom
Dirkster99 merged 1 commit intoDirkster99:masterfrom
Conversation
|
great |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When there's a single document in a floating window like this:
..and you close that document, the next active document becomes Document 2 which changes the selected document in the other pane. Expected behavior is that Document 1 remains the selected document and becomes active.
The implementation uses the global index of the closing document and tries to set the document at index - 1 to active, regardless of the containers.