Skip to content

ENG-1187: Prod: Implement get and set for block prop based settings #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sid597 merged 3 commits into from
Feb 6, 2026
Merged

ENG-1187: Prod: Implement get and set for block prop based settings #669

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
132d1c5
address review
sid597 Jan 5, 2026
98ea51c
address review
sid597 Feb 5, 2026
0fd984d
address michael review
sid597 Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
260 changes: 129 additions & 131 deletions apps/roam/src/components/settings/data/defaultRelationsBlockProps.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,142 +1,140 @@
import type { DiscourseRelationSettings } from "~/components/settings/utils/zodSchema";
/* eslint-disable @typescript-eslint/naming-convention */ // This is for nodePosition keys
import type { DiscourseRelationSettings } from "~/components/settings/utils/zodSchema";

// TODO: Delete the original default relations in data/defaultRelations.ts when fully migrated.
const DEFAULT_RELATIONS_BLOCK_PROPS: DiscourseRelationSettings[] = [
const DEFAULT_RELATIONS_BLOCK_PROPS: Record<string, DiscourseRelationSettings> =
{
id: "informs",
label: "Informs",
source: "_EVD-node",
destination: "_QUE-node",
complement: "Informed By",
ifConditions: [
{
triples: [
["Page", "is a", "source"],
["Block", "references", "Page"],
["Block", "is in page", "ParentPage"],
["ParentPage", "is a", "destination"],
],
nodePositions: {
"0": "100 57",
"1": "100 208",
"2": "100 345",
source: "281 57",
destination: "281 345",
"_INFF-rel": {
Comment thread
sid597 marked this conversation as resolved.
Outdated
label: "Informs",
source: "_EVD-node",
destination: "_QUE-node",
complement: "Informed By",
ifConditions: [
{
triples: [
["Page", "is a", "source"],
["Block", "references", "Page"],
["Block", "is in page", "ParentPage"],
["ParentPage", "is a", "destination"],
],
nodePositions: {
"0": "100 57",
"1": "100 208",
"2": "100 345",
source: "281 57",
destination: "281 345",
},
},
},
],
},
{
id: "supports",
label: "Supports",
source: "_EVD-node",
destination: "_CLM-node",
complement: "Supported By",
ifConditions: [
{
triples: [
["Page", "is a", "source"],
["Block", "references", "Page"],
["SBlock", "references", "SPage"],
["SPage", "has title", "SupportedBy"],
["SBlock", "has child", "Block"],
["PBlock", "references", "ParentPage"],
["PBlock", "has child", "SBlock"],
["ParentPage", "is a", "destination"],
],
nodePositions: {
"0": "250 325",
"1": "100 325",
"2": "100 200",
"3": "250 200",
"4": "400 200",
"5": "100 75",
"6": "250 75",
source: "400 325",
destination: "400 75",
],
},
"_SUPP-rel": {
label: "Supports",
source: "_EVD-node",
destination: "_CLM-node",
complement: "Supported By",
ifConditions: [
{
triples: [
["Page", "is a", "source"],
["Block", "references", "Page"],
["SBlock", "references", "SPage"],
["SPage", "has title", "SupportedBy"],
["SBlock", "has child", "Block"],
["PBlock", "references", "ParentPage"],
["PBlock", "has child", "SBlock"],
["ParentPage", "is a", "destination"],
],
nodePositions: {
"0": "250 325",
"1": "100 325",
"2": "100 200",
"3": "250 200",
"4": "400 200",
"5": "100 75",
"6": "250 75",
source: "400 325",
destination: "400 75",
},
},
},
{
triples: [
["Page", "is a", "destination"],
["Block", "references", "Page"],
["SBlock", "references", "SPage"],
["SPage", "has title", "Supports"],
["SBlock", "has child", "Block"],
["PBlock", "references", "ParentPage"],
["PBlock", "has child", "SBlock"],
["ParentPage", "is a", "source"],
],
nodePositions: {
"7": "250 325",
"8": "100 325",
"9": "100 200",
"10": "250 200",
"11": "400 200",
"12": "100 75",
"13": "250 75",
source: "400 75",
destination: "400 325",
{
triples: [
["Page", "is a", "destination"],
["Block", "references", "Page"],
["SBlock", "references", "SPage"],
["SPage", "has title", "Supports"],
["SBlock", "has child", "Block"],
["PBlock", "references", "ParentPage"],
["PBlock", "has child", "SBlock"],
["ParentPage", "is a", "source"],
],
nodePositions: {
"7": "250 325",
"8": "100 325",
"9": "100 200",
"10": "250 200",
"11": "400 200",
"12": "100 75",
"13": "250 75",
source: "400 75",
destination: "400 325",
},
},
},
],
},
{
id: "opposes",
label: "Opposes",
source: "_EVD-node",
destination: "_CLM-node",
complement: "Opposed By",
ifConditions: [
{
triples: [
["Page", "is a", "source"],
["Block", "references", "Page"],
["SBlock", "references", "SPage"],
["SPage", "has title", "OpposedBy"],
["SBlock", "has child", "Block"],
["PBlock", "references", "ParentPage"],
["PBlock", "has child", "SBlock"],
["ParentPage", "is a", "destination"],
],
nodePositions: {
"0": "250 325",
"1": "100 325",
"2": "100 200",
"3": "250 200",
"4": "400 200",
"5": "100 75",
"6": "250 75",
source: "400 325",
destination: "400 75",
],
},
"_OPPP-rel": {
Comment thread
sid597 marked this conversation as resolved.
Outdated
label: "Opposes",
source: "_EVD-node",
destination: "_CLM-node",
complement: "Opposed By",
ifConditions: [
{
triples: [
["Page", "is a", "source"],
["Block", "references", "Page"],
["SBlock", "references", "SPage"],
["SPage", "has title", "OpposedBy"],
["SBlock", "has child", "Block"],
["PBlock", "references", "ParentPage"],
["PBlock", "has child", "SBlock"],
["ParentPage", "is a", "destination"],
],
nodePositions: {
"0": "250 325",
"1": "100 325",
"2": "100 200",
"3": "250 200",
"4": "400 200",
"5": "100 75",
"6": "250 75",
source: "400 325",
destination: "400 75",
},
},
},
{
triples: [
["Page", "is a", "destination"],
["Block", "references", "Page"],
["SBlock", "references", "SPage"],
["SPage", "has title", "Opposes"],
["SBlock", "has child", "Block"],
["PBlock", "references", "ParentPage"],
["PBlock", "has child", "SBlock"],
["ParentPage", "is a", "source"],
],
nodePositions: {
"7": "250 325",
"8": "100 325",
"9": "100 200",
"10": "250 200",
"11": "400 200",
"12": "100 75",
"13": "250 75",
source: "400 75",
destination: "400 325",
{
triples: [
["Page", "is a", "destination"],
["Block", "references", "Page"],
["SBlock", "references", "SPage"],
["SPage", "has title", "Opposes"],
["SBlock", "has child", "Block"],
["PBlock", "references", "ParentPage"],
["PBlock", "has child", "SBlock"],
["ParentPage", "is a", "source"],
],
nodePositions: {
"7": "250 325",
"8": "100 325",
"9": "100 200",
"10": "250 200",
"11": "400 200",
"12": "100 75",
"13": "250 75",
source: "400 75",
destination: "400 325",
},
},
},
],
},
];
],
},
};

export default DEFAULT_RELATIONS_BLOCK_PROPS;
Loading