Skip to content

ENG-1574: Add dual-read console logs to setting setters #914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sid597 merged 7 commits into from
Apr 1, 2026
Merged

ENG-1574: Add dual-read console logs to setting setters #914

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c6c4252
ENG-1574: Add dual-read console logs to setting setters
sid597 Mar 26, 2026
9ad41cf
Merge origin/eng-1470-test-dual-read-with-flag-on-and-fix-gapsv2
sid597 Mar 27, 2026
699e475
ENG-1574: Add init-time dual-read log and window.dgDualReadLog()
sid597 Mar 27, 2026
b876cc9
ENG-1574: Fix eslint naming-convention warnings in init.ts
sid597 Mar 27, 2026
1567b3d
ENG-1574: Use deepEqual instead of JSON.stringify for comparison
sid597 Mar 27, 2026
e807ddf
ENG-1574: Remove dead code, use deepEqual for comparison
sid597 Mar 27, 2026
2397446
ENG-1574: Fix review feedback — try-catch, flag exclusion, type guard
sid597 Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 51 additions & 0 deletions apps/roam/src/components/settings/utils/accessors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -777,6 +777,18 @@ export const setFeatureFlag = (
): void => {
const validatedValue = z.boolean().parse(value);

const legacyReader = FEATURE_FLAG_LEGACY_MAP[key];
const legacyValue = legacyReader ? legacyReader() : undefined;
const currentBlockProps = getFeatureFlags()[key];
const match = currentBlockProps === legacyValue;
console.groupCollapsed(
`[DG Dual-Read] Set Feature Flag > ${key} — ${match ? "Settings match" : "Settings don't match"}`,
);
console.log("Legacy:", legacyValue);
console.log("Block props:", currentBlockProps);
console.log("New value:", validatedValue);
console.groupEnd();
Comment thread
sid597 marked this conversation as resolved.
Outdated

setBlockPropBasedSettings({
keys: [TOP_LEVEL_BLOCK_PROP_KEYS.featureFlags, key],
value: validatedValue,
Expand Down Expand Up @@ -832,6 +844,18 @@ export const setGlobalSetting = (keys: string[], value: json): void => {
return;
}

const currentBlockProps = readPathValue(getGlobalSettings(), keys);
const legacyValue = getLegacyGlobalSetting(keys);
const match =
JSON.stringify(currentBlockProps) === JSON.stringify(legacyValue);
Comment thread
sid597 marked this conversation as resolved.
Outdated
console.groupCollapsed(
`[DG Dual-Read] Set Global > ${formatSettingPath(keys)} — ${match ? "Settings match" : "Settings don't match"}`,
);
console.log("Legacy:", legacyValue);
console.log("Block props:", currentBlockProps);
console.log("New value:", value);
console.groupEnd();

setBlockPropBasedSettings({
keys: [TOP_LEVEL_BLOCK_PROP_KEYS.global, ...keys],
value,
Expand Down Expand Up @@ -906,6 +930,18 @@ export const setPersonalSetting = (keys: string[], value: json): void => {
return;
}

const currentBlockProps = readPathValue(getPersonalSettings(), keys);
const legacyValue = getLegacyPersonalSetting(keys);
const match =
JSON.stringify(currentBlockProps) === JSON.stringify(legacyValue);
console.groupCollapsed(
`[DG Dual-Read] Set Personal > ${formatSettingPath(keys)} — ${match ? "Settings match" : "Settings don't match"}`,
);
console.log("Legacy:", legacyValue);
console.log("Block props:", currentBlockProps);
console.log("New value:", value);
console.groupEnd();

setBlockPropBasedSettings({
keys: [personalKey, ...keys],
value,
Expand Down Expand Up @@ -1013,6 +1049,21 @@ export const setDiscourseNodeSetting = (
return;
}

const currentSettings = getDiscourseNodeSettings(nodeType);
const currentBlockPropsValue = currentSettings
? readPathValue(currentSettings, keys)
: undefined;
const legacyValue = getLegacyDiscourseNodeSetting(nodeType, keys);
const match =
JSON.stringify(currentBlockPropsValue) === JSON.stringify(legacyValue);
console.groupCollapsed(
`[DG Dual-Read] Set Discourse Node (${nodeType}) > ${formatSettingPath(keys)} — ${match ? "Settings match" : "Settings don't match"}`,
);
console.log("Legacy:", legacyValue);
console.log("Block props:", currentBlockPropsValue);
console.log("New value:", value);
console.groupEnd();

setBlockPropAtPath(pageUid, keys, value);
};

Expand Down
2 changes: 1 addition & 1 deletion apps/roam/src/utils/storedRelations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

import { USE_STORED_RELATIONS } from "~/data/userSettings";
import { getSetting, setSetting } from "./extensionSettings";
import { DISCOURSE_CONFIG_PAGE_TITLE } from "./renderNodeConfigPage";
import { DISCOURSE_CONFIG_PAGE_TITLE } from "~/data/constants";

const INSTALL_CUTOFF = Date.parse("2026-03-01T00:00:00.000Z");

Expand Down