ENG-739 Move color selector from Canvas to General tab#945
ENG-739 Move color selector from Canvas to General tab#945trangdoan982 wants to merge 3 commits intomainfrom
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| uid={tagUid} | ||
| inputStyle={color ? { color } : undefined} | ||
| /> | ||
| <div> |
There was a problem hiding this comment.
If we no longer need the 4px bottom margin, change this to <>
| inputStyle={color ? { color } : undefined} | ||
| /> | ||
| <div> | ||
| <Label style={{ marginBottom: "4px" }}>Color</Label> |
There was a problem hiding this comment.
Wrap ControlGroup in Label to match other fields above, ref
and remove the marginBottom: 4px (this covered by blueprint styling of bp3-label)
| /> | ||
| <div> | ||
| <Label style={{ marginBottom: "4px" }}>Color</Label> | ||
| <ControlGroup> |
There was a problem hiding this comment.
Add ToolTip after Color to match the other fields (which the above components are using Description, see DiscourseNodeTextPanel).
"Changes the color of tags and canvas nodes"
| order={2} | ||
| parentUid={node.type} | ||
| uid={tagUid} | ||
| inputStyle={color ? { color } : undefined} |
There was a problem hiding this comment.
When set to white (or dark if user has a dark theme), the text would be not visible. So let's revert this in favor of ENG-906: Add node tag below tag input in setting (which is out of scope for this PR)
2 participants
Summary
After changing setting, node tag and node menu reflects the changes fron General tab
Canvas no longer has color picker
Closes ENG-739
🤖 Generated with Claude Code