feat: Add short negative caching for failed URL fetches#28
Open
feat: Add short negative caching for failed URL fetches#28
Conversation
Previously, failed fetches (blocked sites, timeouts, etc.) were never cached, causing every request for the same URL to re-hit the target site. This wastes resources and can trigger further rate limiting. Failed results are now cached for 5 minutes. Successful results retain no explicit TTL (evicted by LRU as before). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously, failed fetches (blocked sites, timeouts, captcha pages) were never cached. This meant every request for the same blocked URL would re-hit the target site, wasting resources and potentially triggering further rate limiting.
This adds a 5-minute negative cache for empty/failed results. Successful results retain no explicit TTL (evicted by LRU as before).
How it works
Context
Related to Doist/Issues#19500 — URLs pasted into Todoist no longer consistently convert to titles.