Merged
Conversation
Contributor
Reviewer's Guide by SourceryThis pull request includes several small bug fixes and improvements. It refactors the Updated class diagram for EnumBoxclassDiagram
class EnumBox~T~ {
-String current
-List~Widget~ Function(BuildContext context) itemBuilder
-Widget labelWidget
-bool useBottomSheet
+Widget build(BuildContext context)
}
Class diagram for showBottomSheetPillclassDiagram
class showBottomSheetPill {
+Future~void~ showBottomSheetPill(
BuildContext context,
Widget Function(BuildContext context, ScrollController scrollController) content
)
}
Updated class diagram for _LibrarySearchBottomBarclassDiagram
class _LibrarySearchBottomBar {
+Widget build(BuildContext context, WidgetRef ref)
}
Updated class diagram for NavigationScaffoldclassDiagram
class NavigationScaffold {
+bool resizeToAvoidBottomInset
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey @PartyDonut - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding more descriptive commit messages to explain the purpose and impact of each bug fix.
- The removal of MediaQueryData seems like a potentially breaking change; ensure it's thoroughly tested on different devices.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Review instructions: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| ) content, | ||
| }) async { | ||
| final screenSize = MediaQuery.sizeOf(context); | ||
| log(screenSize.height.toString()); |
Contributor
There was a problem hiding this comment.
suggestion: Debug log statement left in modal bottom sheet.
Logging the screen height can be valuable for debugging but may not be ideal to keep in production code. Consider gating it behind a debug flag or removing it if it is no longer necessary.
Suggested implementation:
import 'package:flutter/material.dart';
import 'package:flutter/foundation.dart';
final screenSize = MediaQuery.sizeOf(context);
if (kDebugMode) {
log(screenSize.height.toString());
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Small bugfixes