Skip to content

Chore/upgrade packages#304

Merged
PartyDonut merged 5 commits intodevelopfrom
chore/upgrade-packages
Apr 6, 2025
Merged

Chore/upgrade packages#304
PartyDonut merged 5 commits intodevelopfrom
chore/upgrade-packages

Conversation

@PartyDonut
Copy link
Copy Markdown
Collaborator

Pull Request Description

Updated the media player backends

@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai bot commented Apr 6, 2025

Reviewer's Guide by Sourcery

This pull request updates media player backend packages, improves UI components, and adds a volume controller plugin for Windows. It also includes minor fixes and improvements to the dashboard and client settings screens.

Updated class diagram for EnumBox

classDiagram
  class EnumBox~T~ {
    -String current
    -List~T~ items
    -String Function(T) labelBuilder
    -void Function(T) onSelected
    -String title
    -bool useBottomSheet
    +Widget build(BuildContext context)
  }
Loading

File-Level Changes

Change Details Files
Updated media player backend packages.
  • Updated media_kit from 1.1.11 to 1.2.0.
  • Updated fvp from 0.29.0 to 0.31.0.
pubspec.yaml
Removed MediaQuery widget in SettingsListTile.
  • Removed the MediaQuery widget that was wrapping the ListTile.
lib/screens/settings/settings_list_tile.dart
Updated language display in client settings.
  • Modified the language display to include the language code in parentheses.
lib/screens/settings/client_sections/client_settings_visual.dart
Improved bottom sheet implementation.
  • Added scroll controller to the content of the showBottomSheetPill function.
  • Added adaptive constraints to the bottom sheet to better fit different screen sizes.
  • Wrapped the content of the bottom sheet in a ListView to enable scrolling.
lib/widgets/shared/enum_selection.dart
lib/widgets/shared/modal_bottom_sheet.dart
Updated icons in the library search and carousel banner widgets.
  • Updated the arrow up icon in the library search bottom bar.
  • Updated the arrow left icon in the carousel banner.
lib/screens/library_search/library_search_screen.dart
lib/screens/shared/media/carousel_banner.dart
Added volume controller plugin for Windows.
  • Registered the VolumeControllerPluginCApi in generated_plugin_registrant.cc.
  • Added volume_controller to FLUTTER_PLUGIN_LIST in generated_plugins.cmake.
  • Registered VolumeControllerPlugin in GeneratedPluginRegistrant.swift.
windows/flutter/generated_plugin_registrant.cc
windows/flutter/generated_plugins.cmake
macos/Flutter/GeneratedPluginRegistrant.swift
Added default top padding to the dashboard screen.
  • Added DefaultSliverTopBadding to the dashboard screen.
lib/screens/dashboard/dashboard_screen.dart
Added a divider to the client settings page.
  • Added a Divider widget to the client settings page.
lib/screens/settings/client_settings_page.dart
Set resizeToAvoidBottomInset to false in NavigationScaffold.
  • Set resizeToAvoidBottomInset to false in NavigationScaffold to prevent resizing when the keyboard appears.
lib/widgets/navigation_scaffold/navigation_scaffold.dart

Possibly linked issues

  • #0: The PR upgrades the media_kit and fvp packages, directly addressing the issue of improving the media player.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @PartyDonut - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider removing the dependency overrides now that you've upgraded the packages.
  • The removal of the MediaQuery widget seems like a good simplification.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Review instructions: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@PartyDonut PartyDonut merged commit 370a503 into develop Apr 6, 2025
11 checks passed
@PartyDonut PartyDonut deleted the chore/upgrade-packages branch April 6, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant