Skip to content

feature(PhotoViewer): Keep screen alive during slideshow#305

Merged
PartyDonut merged 1 commit intodevelopfrom
feature/photo-viewer-improvements
Apr 6, 2025
Merged

feature(PhotoViewer): Keep screen alive during slideshow#305
PartyDonut merged 1 commit intodevelopfrom
feature/photo-viewer-improvements

Conversation

@PartyDonut
Copy link
Copy Markdown
Collaborator

Pull Request Description

Keep screen alive during slideshow
Added full-screen toggle

fix(PhotoViewer): Full-screen toggle desktops
@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai bot commented Apr 6, 2025

Reviewer's Guide by Sourcery

This pull request adds functionality to keep the screen on during slideshows using Wakelock and introduces a full-screen toggle button for desktop platforms in the photo viewer.

Sequence diagram for slideshow timer lifecycle

sequenceDiagram
  participant User
  participant RestartableTimerController
  participant WakelockPlus

  User->>RestartableTimerController: Starts slideshow
  activate RestartableTimerController
  RestartableTimerController->>WakelockPlus: enable()
  activate WakelockPlus
  WakelockPlus-->>RestartableTimerController: (Screen stays on)
  deactivate WakelockPlus
  RestartableTimerController->>RestartableTimerController: Starts timer
  RestartableTimerController-->>User: Slideshow progresses

  User->>RestartableTimerController: Stops slideshow
  RestartableTimerController->>WakelockPlus: disable()
  activate WakelockPlus
  WakelockPlus-->>RestartableTimerController: (Screen can turn off)
  deactivate WakelockPlus
  RestartableTimerController->>RestartableTimerController: Cancels timer
  deactivate RestartableTimerController
Loading

File-Level Changes

Change Details Files
Implemented wakelock to keep the screen on during slideshows, preventing the device from sleeping.
  • Added the wakelock_plus package as a dependency.
  • Enabled wakelock when the slideshow timer starts.
  • Disabled wakelock when the slideshow timer is cancelled or disposed.
lib/widgets/shared/progress_floating_button.dart
Added a full-screen toggle button for desktop platforms in the photo viewer controls.
  • Added a FullScreenButton widget that is conditionally rendered based on the platform.
  • Imported full_screen_button.dart or full_screen_button_web.dart based on the platform.
  • Added closeFullScreen() to the dispose method.
lib/screens/photo_viewer/photo_viewer_controls.dart

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @PartyDonut - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding a comment explaining why WakelockPlus.disable() is called in multiple places.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Review instructions: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@PartyDonut PartyDonut added the feature New feature or request label Apr 6, 2025
@PartyDonut PartyDonut changed the title fix(PhotoViewer): Keep screen alive during slideshow feature(PhotoViewer): Keep screen alive during slideshow Apr 6, 2025
@PartyDonut PartyDonut merged commit 2485dcf into develop Apr 6, 2025
1 check passed
@PartyDonut PartyDonut deleted the feature/photo-viewer-improvements branch April 6, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant