feature(PhotoViewer): Keep screen alive during slideshow#305
Merged
PartyDonut merged 1 commit intodevelopfrom Apr 6, 2025
Merged
feature(PhotoViewer): Keep screen alive during slideshow#305PartyDonut merged 1 commit intodevelopfrom
PartyDonut merged 1 commit intodevelopfrom
Conversation
fix(PhotoViewer): Full-screen toggle desktops
Contributor
Reviewer's Guide by SourceryThis pull request adds functionality to keep the screen on during slideshows using Wakelock and introduces a full-screen toggle button for desktop platforms in the photo viewer. Sequence diagram for slideshow timer lifecyclesequenceDiagram
participant User
participant RestartableTimerController
participant WakelockPlus
User->>RestartableTimerController: Starts slideshow
activate RestartableTimerController
RestartableTimerController->>WakelockPlus: enable()
activate WakelockPlus
WakelockPlus-->>RestartableTimerController: (Screen stays on)
deactivate WakelockPlus
RestartableTimerController->>RestartableTimerController: Starts timer
RestartableTimerController-->>User: Slideshow progresses
User->>RestartableTimerController: Stops slideshow
RestartableTimerController->>WakelockPlus: disable()
activate WakelockPlus
WakelockPlus-->>RestartableTimerController: (Screen can turn off)
deactivate WakelockPlus
RestartableTimerController->>RestartableTimerController: Cancels timer
deactivate RestartableTimerController
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey @PartyDonut - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a comment explaining why
WakelockPlus.disable()is called in multiple places.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Review instructions: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Keep screen alive during slideshow
Added full-screen toggle