Skip to content

fix: Ends at calculation when playbackrate is not 1x#325

Merged
PartyDonut merged 1 commit intoDonutWare:developfrom
Julien9969:fix-end-at-when-speed-up
May 4, 2025
Merged

fix: Ends at calculation when playbackrate is not 1x#325
PartyDonut merged 1 commit intoDonutWare:developfrom
Julien9969:fix-end-at-when-speed-up

Conversation

@Julien9969
Copy link
Copy Markdown
Contributor

Pull Request Description

The "Ends at" on player controls display end time with date + runtime, so it does not consider the playrate.

Checklist

  • If a new package was added, did you ensure it works for all supported platforms? Is the package well maintained
  • Check that any changes are related to the issue at hand.

@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai bot commented May 4, 2025

Reviewer's Guide

This PR updates the 'Ends at' time calculation in the video player controls by dividing the remaining duration (in milliseconds) by the current playback rate before adding it to the current time. This ensures the displayed end time accurately reflects variations in playback speed.

File-Level Changes

Change Details Files
Factor playback rate into 'Ends at' time calculation.
  • Calculate remaining duration in milliseconds.
  • Divide remaining milliseconds by the playback rate.
  • Add the adjusted duration to the current time to get the correct end time based on playback speed.
lib/screens/video_player/video_player_controls.dart

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Julien9969 - I've reviewed your changes - here's some feedback:

  • Consider extracting the remaining duration calculation into a variable for readability.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Review instructions: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@PartyDonut PartyDonut added the bug Something isn't working label May 4, 2025
Copy link
Copy Markdown
Collaborator

@PartyDonut PartyDonut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for splitting it up 👍🏼

@PartyDonut PartyDonut merged commit 3bb1b35 into DonutWare:develop May 4, 2025
1 check passed
@github-project-automation github-project-automation bot moved this to Done in Fladder May 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants