fix: Ends at calculation when playbackrate is not 1x#325
Merged
PartyDonut merged 1 commit intoDonutWare:developfrom May 4, 2025
Merged
fix: Ends at calculation when playbackrate is not 1x#325PartyDonut merged 1 commit intoDonutWare:developfrom
PartyDonut merged 1 commit intoDonutWare:developfrom
Conversation
Contributor
Reviewer's GuideThis PR updates the 'Ends at' time calculation in the video player controls by dividing the remaining duration (in milliseconds) by the current playback rate before adding it to the current time. This ensures the displayed end time accurately reflects variations in playback speed. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey @Julien9969 - I've reviewed your changes - here's some feedback:
- Consider extracting the remaining duration calculation into a variable for readability.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Review instructions: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
PartyDonut
approved these changes
May 4, 2025
Collaborator
PartyDonut
left a comment
There was a problem hiding this comment.
LGTM, Thanks for splitting it up 👍🏼
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
The "Ends at" on player controls display end time with date + runtime, so it does not consider the playrate.
Checklist